[HttpFoundation] Fixed isSecure() check to be compliant with the docs

Jannik Zschiesche · fabpot · commit b380fdd8fea7 · 2014-06-16T09:30:49.000+02:00
diff --git a/Request.php b/Request.php
@@ -1100,7 +1100,9 @@ public function isSecure()
             return in_array(strtolower(current(explode(',', $proto))), array('https', 'on', 'ssl', '1'));
         }
 
-        return 'on' == strtolower($this->server->get('HTTPS')) || 1 == $this->server->get('HTTPS');
+        $https = $this->server->get('HTTPS');
+
+        return !empty($https) && 'off' !== strtolower($https);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -1100,7 +1100,9 @@ public function isSecure()`
`1100`	`1100`	`return in_array(strtolower(current(explode(',', $proto))), array('https', 'on', 'ssl', '1'));`
`1101`	`1101`	`}`
`1102`	`1102`
`1103`		`- return 'on' == strtolower($this->server->get('HTTPS')) \|\| 1 == $this->server->get('HTTPS');`
	`1103`	`+ $https = $this->server->get('HTTPS');`
	`1104`	`+`
	`1105`	`+ return !empty($https) && 'off' !== strtolower($https);`
`1104`	`1106`	`}`
`1105`	`1107`
`1106`	`1108`	`/**`