Skip to content

Commit 6f98c1c

Browse files
minor #28675 [CS] Enforces null type hint on last position in phpDocs (carusogabriel)
This PR was merged into the 2.8 branch. Discussion ---------- [CS] Enforces null type hint on last position in phpDocs | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | - <!-- required for new features --> As a majority in our codebase, the `null` typehint usually comes in the last position in phpDocs. Commits ------- efbba25577 [CS] Enforces null type hint on last position in phpDocs
2 parents 5d8d0ec + 639cb35 commit 6f98c1c

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

BinaryFileResponse.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class BinaryFileResponse extends Response
4040
* @param int $status The response status code
4141
* @param array $headers An array of response headers
4242
* @param bool $public Files are public by default
43-
* @param null|string $contentDisposition The type of Content-Disposition to set automatically with the filename
43+
* @param string|null $contentDisposition The type of Content-Disposition to set automatically with the filename
4444
* @param bool $autoEtag Whether the ETag header should be automatically set
4545
* @param bool $autoLastModified Whether the Last-Modified header should be automatically set
4646
*/
@@ -60,7 +60,7 @@ public function __construct($file, $status = 200, $headers = array(), $public =
6060
* @param int $status The response status code
6161
* @param array $headers An array of response headers
6262
* @param bool $public Files are public by default
63-
* @param null|string $contentDisposition The type of Content-Disposition to set automatically with the filename
63+
* @param string|null $contentDisposition The type of Content-Disposition to set automatically with the filename
6464
* @param bool $autoEtag Whether the ETag header should be automatically set
6565
* @param bool $autoLastModified Whether the Last-Modified header should be automatically set
6666
*

HeaderBag.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ public function remove($key)
197197
* @param string $key The parameter key
198198
* @param \DateTime $default The default value
199199
*
200-
* @return null|\DateTime The parsed DateTime or the default value if the header does not exist
200+
* @return \DateTime|null The parsed DateTime or the default value if the header does not exist
201201
*
202202
* @throws \RuntimeException When the HTTP header is not parseable
203203
*/

Session/Storage/Handler/PdoSessionHandler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ class PdoSessionHandler implements \SessionHandlerInterface
7171
private $pdo;
7272

7373
/**
74-
* @var string|null|false DSN string or null for session.save_path or false when lazy connection disabled
74+
* @var string|false|null DSN string or null for session.save_path or false when lazy connection disabled
7575
*/
7676
private $dsn = false;
7777

0 commit comments

Comments
 (0)