bug #33691 [HttpClient] fix race condition when reading response with informational status (nicolas-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] fix race condition when reading response with informational status

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Spotted by some transiently failing jobs on Travis.

Commits
-------

450c3c4998 [HttpClient] fix race condition when reading response with informational status

Author: nicolas-grekas

CurlHttpClient.php

@@ -355,7 +355,7 @@ private static function handlePush($parent, $pushed, array $requestHeaders, Curl
      */
     private static function acceptPushForRequest(string $method, array $options, PushedResponse $pushedResponse): bool
     {
-        if ($options['body'] || $method !== $pushedResponse->requestHeaders[':method'][0]) {
+        if ('' !== $options['body'] || $method !== $pushedResponse->requestHeaders[':method'][0]) {
             return false;
         }
 

Response/CurlResponse.php

@@ -121,15 +121,17 @@ public function __construct(CurlClientState $multi, $ch, array $options = null,
 
             if (\in_array($waitFor, ['headers', 'destruct'], true)) {
                 try {
-                    self::stream([$response])->current();
+                    foreach (self::stream([$response]) as $chunk) {
+                        if ($chunk->isFirst()) {
+                            break;
+                        }
+                    }
                 } catch (\Throwable $e) {
                     // Persist timeouts thrown during initialization
                     $response->info['error'] = $e->getMessage();
                     $response->close();
                     throw $e;
                 }
-            } elseif ('content' === $waitFor && ($response->multi->handlesActivity[$response->id][0] ?? null) instanceof FirstChunk) {
-                self::stream([$response])->current();
             }
 
             curl_setopt($ch, CURLOPT_HEADERFUNCTION, null);

Response/NativeResponse.php

@@ -65,7 +65,11 @@ public function __construct(NativeClientState $multi, $context, string $url, $op
             }
 
             if (null === $response->remaining) {
-                self::stream([$response])->current();
+                foreach (self::stream([$response]) as $chunk) {
+                    if ($chunk->isFirst()) {
+                        break;
+                    }
+                }
             }
         };
     }