Skip to content

Commit fc06123

Browse files
committed
Merge branch '2.5'
* 2.5: Update validators.eu.xlf fixed CS remove unused imports [Validator] Added markObjectAsInitialized() and isObjectInitialized() to ExecutionContextInterface [Validator] Fixed doc block [Routing] simplify the XML schema file Unify null comparisons [EventDispatcher] don't count empty listeners [Process] Fix unit tests in sigchild environment [Process] fix signal handling in wait() [BrowserKit] refactor code and fix unquoted regex Fixed server HTTP_HOST port uri conversion [HttpFoundation] moved test file to the right directory [Validator] Made sure that context changes don't leak out of (Contextual)ValidatorInterface [MonologBridge] fixed Console handler priorities Bring code into standard [Process] Add test to verify fix for issue #11421 [Process] Fixes issue #11421 [DependencyInjection] Pass a Scope instance instead of a scope name.
2 parents e91d61f + 47bf3f8 commit fc06123

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

DependencyInjection/Configuration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function getConfigTreeBuilder()
4141
->end()
4242
->arrayNode('trusted_proxies')
4343
->beforeNormalization()
44-
->ifTrue(function ($v) { return !is_array($v) && !is_null($v); })
44+
->ifTrue(function ($v) { return !is_array($v) && null !== $v; })
4545
->then(function ($v) { return is_bool($v) ? array() : preg_split('/\s*,\s*/', $v); })
4646
->end()
4747
->prototype('scalar')

Resources/views/Form/choice_widget_collapsed.html.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<select
2-
<?php if ($required && $empty_value === null && $empty_value_in_choices === false && $multiple === false):
2+
<?php if ($required && null === $empty_value && $empty_value_in_choices === false && $multiple === false):
33
$required = false;
44
endif; ?>
55
<?php echo $view['form']->block($form, 'widget_attributes', array(

Test/KernelTestCase.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,14 @@ protected static function getPhpUnitXmlDir()
4545
}
4646

4747
$dir = static::getPhpUnitCliConfigArgument();
48-
if ($dir === null &&
48+
if (null === $dir &&
4949
(is_file(getcwd().DIRECTORY_SEPARATOR.'phpunit.xml') ||
5050
is_file(getcwd().DIRECTORY_SEPARATOR.'phpunit.xml.dist'))) {
5151
$dir = getcwd();
5252
}
5353

5454
// Can't continue
55-
if ($dir === null) {
55+
if (null === $dir) {
5656
throw new \RuntimeException('Unable to guess the Kernel directory.');
5757
}
5858

@@ -90,7 +90,7 @@ private static function getPhpUnitCliConfigArgument()
9090
}
9191

9292
/**
93-
* Attempts to guess the Kernel location.
93+
* Attempts to guess the kernel location.
9494
*
9595
* When the Kernel is located, the file is required.
9696
*
@@ -117,7 +117,7 @@ protected static function getKernelClass()
117117
$finder->name('*Kernel.php')->depth(0)->in($dir);
118118
$results = iterator_to_array($finder);
119119
if (!count($results)) {
120-
throw new \RuntimeException('Either set KERNEL_DIR in your phpunit.xml according to http://symfony.com/doc/current/book/testing.html#your-first-functional-test or override the KernelTestCase::createKernel() method.');
120+
throw new \RuntimeException('Either set KERNEL_DIR in your phpunit.xml according to http://symfony.com/doc/current/book/testing.html#your-first-functional-test or override the WebTestCase::createKernel() method.');
121121
}
122122

123123
$file = current($results);
@@ -141,7 +141,7 @@ protected static function bootKernel(array $options = array())
141141
static::$kernel->boot();
142142
}
143143

144-
/**
144+
/**
145145
* Creates a Kernel.
146146
*
147147
* Available options:

Tests/DependencyInjection/Compiler/SerializerPassTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public function testServicesAreOrderedAccordingToPriority()
9696
'Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\SerializerPass',
9797
'findAndSortTaggedServices'
9898
);
99-
$method->setAccessible(TRUE);
99+
$method->setAccessible(true);
100100

101101
$actual = $method->invoke($serializerPass, 'tag', $container);
102102

0 commit comments

Comments
 (0)