merged branch dantleech/enforce_sprintf_for_exceptions (PR #7620)

This PR was squashed before being merged into the master branch (closes #7620).

Discussion
----------

Enforce sprintf for exceptions

| Q             | A
| ------------- | ---
| Bug fix?      |no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | [yes|no]
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | symfony/symfony-docs#2483

Changed format of exceptions which concatenate strings as follows

````
throw new \Exception('The '.$something.' needs the '.$foobar.' parameter');
````

to

````
throw new \Exception(sprintf('The %s needs the %s parameter', $something, $foobar));
````

This follows discussion on mailing list: https://groups.google.com/forum/?fromgroups#!topic/symfony-devs/tecj3UOAueM

Unit test results are pending...

Commits
-------

e655120 Enforce sprintf for exceptions

Author: fabpot

Command/ConfigDumpReferenceCommand.php

@@ -84,7 +84,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
 
             if (!$extension) {
-                throw new \LogicException('No extensions with configuration available for "'.$name.'"');
+                throw new \LogicException(sprintf('No extensions with configuration available for "%s"', $name));
             }
 
             $message = 'Default configuration for "'.$name.'"';
@@ -100,7 +100,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
 
             if (!$extension) {
-                throw new \LogicException('No extension with alias "'.$name.'" is enabled');
+                throw new \LogicException(sprintf('No extension with alias "%s" is enabled', $name));
             }
 
             $message = 'Default configuration for extension with alias: "'.$name.'"';
@@ -109,14 +109,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $configuration = $extension->getConfiguration(array(), $containerBuilder);
 
         if (!$configuration) {
-            throw new \LogicException('The extension with alias "'.$extension->getAlias().
-                    '" does not have it\'s getConfiguration() method setup');
+            throw new \LogicException(sprintf('The extension with alias "%s" does not have it\'s getConfiguration() method setup', $extension->getAlias()));
         }
 
         if (!$configuration instanceof ConfigurationInterface) {
-            throw new \LogicException(
-                'Configuration class "'.get_class($configuration).
-                '" should implement ConfigurationInterface in order to be dumpable');
+            throw new \LogicException(sprintf('Configuration class "%s" should implement ConfigurationInterface in order to be dumpable', get_class($configuration)));
         }
 
         $output->writeln($message);