Skip to content

Commit ed72a28

Browse files
committed
remove the ChatterInterface alias when the chatter service is removed
1 parent 8e094cb commit ed72a28

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,10 @@
162162
use Symfony\Component\Notifier\Bridge\Vonage\VonageTransportFactory;
163163
use Symfony\Component\Notifier\Bridge\Yunpian\YunpianTransportFactory;
164164
use Symfony\Component\Notifier\Bridge\Zulip\ZulipTransportFactory;
165+
use Symfony\Component\Notifier\ChatterInterface;
165166
use Symfony\Component\Notifier\Notifier;
166167
use Symfony\Component\Notifier\Recipient\Recipient;
168+
use Symfony\Component\Notifier\TexterInterface;
167169
use Symfony\Component\Notifier\Transport\TransportFactoryInterface as NotifierTransportFactoryInterface;
168170
use Symfony\Component\PropertyAccess\PropertyAccessor;
169171
use Symfony\Component\PropertyInfo\Extractor\PhpStanExtractor;
@@ -2489,11 +2491,13 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $
24892491
$container->getDefinition('chatter.transports')->setArgument(0, $config['chatter_transports']);
24902492
} else {
24912493
$container->removeDefinition('chatter');
2494+
$container->removeAlias(ChatterInterface::class);
24922495
}
24932496
if ($config['texter_transports']) {
24942497
$container->getDefinition('texter.transports')->setArgument(0, $config['texter_transports']);
24952498
} else {
24962499
$container->removeDefinition('texter');
2500+
$container->removeAlias(TexterInterface::class);
24972501
}
24982502

24992503
if ($this->mailerConfigEnabled) {

Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@
5353
use Symfony\Component\HttpKernel\DependencyInjection\LoggerPass;
5454
use Symfony\Component\HttpKernel\Fragment\FragmentUriGeneratorInterface;
5555
use Symfony\Component\Messenger\Transport\TransportFactory;
56+
use Symfony\Component\Notifier\ChatterInterface;
57+
use Symfony\Component\Notifier\TexterInterface;
5658
use Symfony\Component\PropertyAccess\PropertyAccessor;
5759
use Symfony\Component\Security\Core\Security;
5860
use Symfony\Component\Serializer\Mapping\Loader\AnnotationLoader;
@@ -2022,7 +2024,9 @@ public function testNotifierWithoutTransports()
20222024

20232025
$this->assertTrue($container->hasDefinition('notifier'));
20242026
$this->assertFalse($container->hasDefinition('chatter'));
2027+
$this->assertFalse($container->hasAlias(ChatterInterface::class));
20252028
$this->assertFalse($container->hasDefinition('texter'));
2029+
$this->assertFalse($container->hasAlias(TexterInterface::class));
20262030
}
20272031

20282032
public function testIfNotifierTransportsAreKnownByFrameworkExtension()

0 commit comments

Comments
 (0)