minor #19656 [FrameworkBundle][Debug] Fix default config and cleaning of traces (nicolas-grekas)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[FrameworkBundle][Debug] Fix default config and cleaning of traces

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| Tests pass?   | yes
| Fixed tickets | Follow up #19568
| License       | MIT
| Doc PR        | -

The default value of `framework.php_errors.log` must be `%kernel.debug%` to have deprecations and silenced errors logged in dev as before.

Cleaning the trace was broken because a closure can't be bound to an internal class.

This PR fixes both issues and enhance trace cleaning a bit by removing arguments from traces so that they take less memory when collected as part of the context of log messages.

Commits
-------

f640870 [FrameworkBundle][Debug] Fix default config and cleaning of traces

Author: fabpot

DependencyInjection/Configuration.php

@@ -704,8 +704,8 @@ private function addPhpErrorsSection(ArrayNodeDefinition $rootNode)
                     ->children()
                         ->booleanNode('log')
                             ->info('Use the app logger instead of the PHP logger for logging PHP errors.')
-                            ->defaultValue(false)
-                            ->treatNullLike(false)
+                            ->defaultValue($this->debug)
+                            ->treatNullLike($this->debug)
                         ->end()
                         ->booleanNode('throw')
                             ->info('Throw PHP errors as \ErrorException instances.')

Tests/DependencyInjection/ConfigurationTest.php

@@ -275,7 +275,7 @@ protected static function getBundleDefaultConfig()
             ),
             'workflows' => array(),
             'php_errors' => array(
-                'log' => false,
+                'log' => true,
                 'throw' => true,
             ),
         );