bug #39856 [DomCrawler] improve failure messages of the CrawlerSelectorTextContains constraint (xabbuh)

fabpot · fabpot · commit 9f68fe2bb712 · 2021-08-26T08:52:27.000+02:00
This PR was merged into the 4.4 branch.

Discussion
----------

[DomCrawler] improve failure messages of the CrawlerSelectorTextContains constraint

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33551, #37757
| License       | MIT
| Doc PR        |

Commits
-------

ba451ab7b2 improve failure messages of the CrawlerSelectorTextContains constraint
diff --git a/Tests/Test/WebTestCaseTest.php b/Tests/Test/WebTestCaseTest.php
@@ -183,7 +183,7 @@ public function testAssertSelectorTextNotContains()
     {
         $this->getCrawlerTester(new Crawler('<html><body><h1>Foo'))->assertSelectorTextNotContains('body > h1', 'Bar');
         $this->expectException(AssertionFailedError::class);
-        $this->expectExceptionMessage('matches selector "body > h1" and does not have a node matching selector "body > h1" with content containing "Foo".');
+        $this->expectExceptionMessage('matches selector "body > h1" and the text "Foo" of the node matching selector "body > h1" does not contain "Foo".');
         $this->getCrawlerTester(new Crawler('<html><body><h1>Foo'))->assertSelectorTextNotContains('body > h1', 'Foo');
     }
 
@@ -199,7 +199,7 @@ public function testAssertPageTitleContains()
     {
         $this->getCrawlerTester(new Crawler('<html><head><title>Foobar'))->assertPageTitleContains('Foo');
         $this->expectException(AssertionFailedError::class);
-        $this->expectExceptionMessage('matches selector "title" and has a node matching selector "title" with content containing "Bar".');
+        $this->expectExceptionMessage('matches selector "title" and the text "Foo" of the node matching selector "title" contains "Bar".');
         $this->getCrawlerTester(new Crawler('<html><head><title>Foo'))->assertPageTitleContains('Bar');
     }
 
diff --git a/composer.json b/composer.json
@@ -39,7 +39,7 @@
         "symfony/browser-kit": "^4.3|^5.0",
         "symfony/console": "^4.4.21|^5.0",
         "symfony/css-selector": "^3.4|^4.0|^5.0",
-        "symfony/dom-crawler": "^4.3|^5.0",
+        "symfony/dom-crawler": "^4.4.20|^5.2.4",
         "symfony/dotenv": "^4.3.6|^5.0",
         "symfony/polyfill-intl-icu": "~1.0",
         "symfony/form": "^4.3.5|^5.0",

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ public function testAssertSelectorTextNotContains()`
`183`	`183`	`{`
`184`	`184`	`$this->getCrawlerTester(new Crawler('<html><body><h1>Foo'))->assertSelectorTextNotContains('body > h1', 'Bar');`
`185`	`185`	`$this->expectException(AssertionFailedError::class);`
`186`		`- $this->expectExceptionMessage('matches selector "body > h1" and does not have a node matching selector "body > h1" with content containing "Foo".');`
	`186`	`+ $this->expectExceptionMessage('matches selector "body > h1" and the text "Foo" of the node matching selector "body > h1" does not contain "Foo".');`
`187`	`187`	`$this->getCrawlerTester(new Crawler('<html><body><h1>Foo'))->assertSelectorTextNotContains('body > h1', 'Foo');`
`188`	`188`	`}`
`189`	`189`
`@@ -199,7 +199,7 @@ public function testAssertPageTitleContains()`
`199`	`199`	`{`
`200`	`200`	`$this->getCrawlerTester(new Crawler('<html><head><title>Foobar'))->assertPageTitleContains('Foo');`
`201`	`201`	`$this->expectException(AssertionFailedError::class);`
`202`		`- $this->expectExceptionMessage('matches selector "title" and has a node matching selector "title" with content containing "Bar".');`
	`202`	`+ $this->expectExceptionMessage('matches selector "title" and the text "Foo" of the node matching selector "title" contains "Bar".');`
`203`	`203`	`$this->getCrawlerTester(new Crawler('<html><head><title>Foo'))->assertPageTitleContains('Bar');`
`204`	`204`	`}`
`205`	`205`