[HttpFoundation][FrameworkBundle] Keep save auto_start behaviour as in 2.2 and make component values consistent with FrameworkBundle's configuration options.

Author: Drak

CHANGELOG.md

@@ -9,8 +9,7 @@ CHANGELOG
  * added `TimedPhpEngine`
  * added `--clean` option the the `translation:update` command
  * added `http_method_override` option
- * Reintroduce `auto_start` session config flag which control to `SessionListener` to manually start sessions
-   during framework request cycle.
+ * Reintroduce `auto_start` session config flag to instruct the `SessionListener` to manually start session
  * Added session config option `on_demand_mode` to control session start on demand.
 
 2.2.0

DependencyInjection/Configuration.php

@@ -185,7 +185,7 @@ private function addSessionSection(ArrayNodeDefinition $rootNode)
                     ->canBeUnset()
                     ->children()
                         ->booleanNode('auto_start')
-                            ->defaultTrue()
+                            ->defaultFalse()
                             ->info('Flag for SessionListener to start session')
                         ->end()
                         ->enumNode('on_demand_mode')

DependencyInjection/FrameworkExtension.php

@@ -319,18 +319,7 @@ private function registerSessionConfiguration(array $config, ContainerBuilder $c
         $container->setParameter('session.auto_start', $config['auto_start']);
 
         // this controls the session start on demand feature
-        switch ($config['on_demand_mode']) {
-            // already validated
-            case 'on':
-                $demand = SessionStorageInterface::START_ON_DEMAND;
-                break;
-            case 'off':
-                $demand = SessionStorageInterface::NO_START_ON_DEMAND_STRICT;
-                break;
-            case 'off_lax':
-                $demand = SessionStorageInterface::NO_START_ON_DEMAND_LAX;
-        }
-        $container->setParameter('session.storage.on_demand_mode', $demand);
+        $container->setParameter('session.storage.on_demand_mode', $config['on_demand_mode']);
 
         $container->setParameter('session.storage.mock_name', $config['mock_name']);
 

EventListener/SessionListener.php

@@ -31,7 +31,7 @@ class SessionListener implements EventSubscriberInterface
     private $container;
     private $autoStart;
 
-    public function __construct(ContainerInterface $container, $autoStart)
+    public function __construct(ContainerInterface $container, $autoStart = false)
     {
         $this->container = $container;
         $this->autoStart = $autoStart;