[FrameworkBundle] Add soft conflict rule of "cache:clear" + HttpKernel 3.4

Author: nicolas-grekas

Command/CacheClearCommand.php

@@ -15,6 +15,7 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
+use Symfony\Component\HttpKernel\Kernel;
 use Symfony\Component\HttpKernel\KernelInterface;
 use Symfony\Component\Finder\Finder;
 
@@ -56,6 +57,10 @@ protected function execute(InputInterface $input, OutputInterface $output)
     {
         $io = new SymfonyStyle($input, $output);
 
+        if (Kernel::VERSION_ID >= 30400) {
+            throw new \LogicException('The "cache:clear" command in Symfony 3.3 is incompatible with HttpKernel 3.4, please upgrade "symfony/framework-bundle" or downgrade "symfony/http-kernel".');
+        }
+
         $realCacheDir = $this->getContainer()->getParameter('kernel.cache_dir');
         // the old cache dir name must not be longer than the real one to avoid exceeding
         // the maximum length of a directory or file path within it (esp. Windows MAX_PATH)

Tests/Command/CacheClearCommand/CacheClearCommandTest.php

@@ -20,6 +20,7 @@
 use Symfony\Component\Console\Output\NullOutput;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Finder\Finder;
+use Symfony\Component\HttpKernel\Kernel;
 
 class CacheClearCommandTest extends TestCase
 {
@@ -49,6 +50,17 @@ public function testCacheIsFreshAfterCacheClearedWithWarmup()
         $application = new Application($this->kernel);
         $application->setCatchExceptions(false);
 
+        if (Kernel::VERSION_ID >= 30400) {
+            $expectedMsg = 'The "cache:clear" command in Symfony 3.3 is incompatible with HttpKernel 3.4, please upgrade "symfony/framework-bundle" or downgrade "symfony/http-kernel".';
+
+            if (method_exists($this, 'expectException')) {
+                $this->expectException(\LogicException::class);
+                $this->expectExceptionMessage($expectedMsg);
+            } else {
+                $this->setExpectedException(\LogicException::class, $expectedMsg);
+            }
+        }
+
         $application->doRun($input, new NullOutput());
 
         // Ensure that all *.meta files are fresh