[FrameworkBundle] Avoid calling rtrim(null, '/') in AssetsInstallCommand

pavol-tuka · GromNaN · commit 5ae3655a69ac · 2022-01-12T12:20:14.000+01:00
diff --git a/Command/AssetsInstallCommand.php b/Command/AssetsInstallCommand.php
@@ -99,8 +99,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
     {
         /** @var KernelInterface $kernel */
         $kernel = $this->getApplication()->getKernel();
-        $targetArg = rtrim($input->getArgument('target'), '/');
-
+        $targetArg = rtrim($input->getArgument('target') ?? '', '/');
         if (!$targetArg) {
             $targetArg = $this->getPublicDirectory($kernel->getContainer());
         }

Original file line number	Diff line number	Diff line change
`@@ -99,8 +99,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int`
`99`	`99`	`{`
`100`	`100`	`/** @var KernelInterface $kernel */`
`101`	`101`	`$kernel = $this->getApplication()->getKernel();`
`102`		`- $targetArg = rtrim($input->getArgument('target'), '/');`
`103`		`-`
	`102`	`+ $targetArg = rtrim($input->getArgument('target') ?? '', '/');`
`104`	`103`	`if (!$targetArg) {`
`105`	`104`	`$targetArg = $this->getPublicDirectory($kernel->getContainer());`
`106`	`105`	`}`