merged branch Tobion/deprecate-debuggerinterface (PR #8929)

This PR was merged into the master branch.

Discussion
----------

[Templating] deprecate DebuggerInterface

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes: deprecated DebuggerInterface and Debugger
| Tests pass?   | yes
| Fixed tickets | #8926
| License       | MIT

- [x] add suggested optional dependency in templating component to Psr log
- [x] remove ProjectTemplateDebugger from tests

Commits
-------

b853438 [Templating] deprecate DebuggerInterface

Author: fabpot

DependencyInjection/FrameworkExtension.php

@@ -12,6 +12,7 @@
 namespace Symfony\Bundle\FrameworkBundle\DependencyInjection;
 
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\DependencyInjection\DefinitionDecorator;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
@@ -372,6 +373,15 @@ private function registerTemplatingConfiguration(array $config, $ide, ContainerB
         if ($container->getParameter('kernel.debug')) {
             $loader->load('templating_debug.xml');
 
+            $logger = new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE);
+
+            $container->getDefinition('templating.loader.cache')
+                ->addTag('monolog.logger', array('channel' => 'templating'))
+                ->addMethodCall('setLogger', array($logger));
+            $container->getDefinition('templating.loader.chain')
+                ->addTag('monolog.logger', array('channel' => 'templating'))
+                ->addMethodCall('setLogger', array($logger));
+
             $container->setDefinition('templating.engine.php', $container->findDefinition('debug.templating.engine.php'));
             $container->setAlias('debug.templating.engine.php', 'templating.engine.php');
         }

Resources/config/templating.xml

@@ -52,11 +52,9 @@
         <service id="templating.loader.cache" class="%templating.loader.cache.class%" public="false">
             <argument type="service" id="templating.loader.wrapped" />
             <argument>%templating.loader.cache.path%</argument>
-            <call method="setDebugger"><argument type="service" id="templating.debugger" on-invalid="ignore" /></call>
         </service>
 
         <service id="templating.loader.chain" class="%templating.loader.chain.class%" public="false">
-            <call method="setDebugger"><argument type="service" id="templating.debugger" on-invalid="ignore" /></call>
         </service>
 
         <service id="templating.loader" alias="templating.loader.filesystem" />

Resources/config/templating_debug.xml

@@ -5,15 +5,10 @@
     xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
 
     <parameters>
-        <parameter key="templating.debugger.class">Symfony\Bundle\FrameworkBundle\Templating\Debugger</parameter>
         <parameter key="debug.templating.engine.php.class">Symfony\Bundle\FrameworkBundle\Templating\TimedPhpEngine</parameter>
     </parameters>
 
     <services>
-        <service id="templating.debugger" class="%templating.debugger.class%" public="false">
-            <tag name="monolog.logger" channel="templating" />
-            <argument type="service" id="logger" on-invalid="null" />
-        </service>
         <service id="debug.templating.engine.php" class="%debug.templating.engine.php.class%" public="false">
             <argument type="service" id="templating.name_parser" />
             <argument type="service" id="service_container" />

Templating/Debugger.php

@@ -18,6 +18,8 @@
  * Binds the Symfony templating loader debugger to the Symfony logger.
  *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @deprecated Deprecated in 2.4, to be removed in 3.0. Use Psr\Log\LoggerInterface instead.
  */
 class Debugger implements DebuggerInterface
 {