Skip to content

Commit 19e2ee0

Browse files
committed
Merge branch '2.5'
* 2.5: (43 commits) [Form] Fix PHPDoc for builder setData methods The underlying data variable is typed as mixed whereas the methods paramers where typed as array. fixed CS [Intl] Improved bundle reader implementations [Console] guarded against invalid aliases switch before_script to before_install and script to install fixed typo [HttpFoundation] Request - URI - comment improvements [Validator] The ratio of the ImageValidator is rounded to two decimals now [Security] Added more tests remove `service` parameter type from XSD [Intl] Added exception handler to command line scripts [Intl] Fixed a few bugs in TextBundleWriter [Intl] Updated icu.ini up to ICU 53 [Intl] Removed non-working $fallback argument from ArrayAccessibleResourceBundle Use separated function to resolve command and related arguments [SwiftmailerBridge] Bump allowed versions of swiftmailer [FrameworkBundle] Remove invalid markup [Intl] Added "internal" tag to all classes under Symfony\Component\Intl\ResourceBundle Remove routes for removed WebProfiler actions [Security] Fix usage of unexistent method in DoctrineAclCache. ... Conflicts: src/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php src/Symfony/Component/HttpKernel/HttpCache/Esi.php src/Symfony/Component/HttpKernel/Kernel.php src/Symfony/Component/Translation/Tests/Dumper/XliffFileDumperTest.php src/Symfony/Component/Yaml/Parser.php src/Symfony/Component/Yaml/Tests/InlineTest.php
2 parents 2d7c2ce + 998aab8 commit 19e2ee0

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

Command/ServerRunCommand.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,14 @@ private function createPhpProcessBuilder(InputInterface $input, OutputInterface
130130
->locateResource(sprintf('@FrameworkBundle/Resources/config/router_%s.php', $env))
131131
;
132132

133+
if (!file_exists($router)) {
134+
$output->writeln(sprintf('<error>The given router script "%s" does not exist</error>', $router));
135+
136+
return 1;
137+
}
138+
139+
$router = realpath($router);
140+
133141
return new ProcessBuilder(array(PHP_BINARY, '-S', $input->getArgument('address'), $router));
134142
}
135143
}

Resources/views/Form/form_widget_compound.html.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
<div <?php echo $view['form']->block($form, 'widget_container_attributes') ?>>
22
<?php if (!$form->parent && $errors): ?>
3-
<tr>
4-
<td colspan="2">
5-
<?php echo $view['form']->errors($form) ?>
6-
</td>
7-
</tr>
3+
<?php echo $view['form']->errors($form) ?>
84
<?php endif ?>
95
<?php echo $view['form']->block($form, 'form_rows') ?>
106
<?php echo $view['form']->rest($form) ?>

Resources/views/FormTable/form_widget_compound.html.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
<table <?php echo $view['form']->block($form, 'widget_container_attributes') ?>>
2-
<?php if (!$form->parent): ?>
3-
<?php echo $view['form']->errors($form) ?>
2+
<?php if (!$form->parent && $errors): ?>
3+
<tr>
4+
<td colspan="2">
5+
<?php echo $view['form']->errors($form) ?>
6+
</td>
7+
</tr>
48
<?php endif ?>
59
<?php echo $view['form']->block($form, 'form_rows') ?>
610
<?php echo $view['form']->rest($form) ?>

0 commit comments

Comments
 (0)