minor #47370 Remove usage of empty function when possible (alamirault)

This PR was squashed before being merged into the 6.2 branch.

Discussion
----------

Remove usage of empty function when possible

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

In recent code reviews we suggest to use `!$var` instead of `empty($var)`

In order to keep same code style in codebase, I replaced usages of empty when it is possible and typehinted

Commits
-------

026edbe601 Remove usage of empty function when possible

Author: fabpot

Command/ContainerDebugCommand.php

@@ -276,7 +276,7 @@ private function findProperServiceName(InputInterface $input, SymfonyStyle $io,
         }
 
         $matchingServices = $this->findServiceIdsContaining($builder, $name, $showHidden);
-        if (empty($matchingServices)) {
+        if (!$matchingServices) {
             throw new InvalidArgumentException(sprintf('No services found that match "%s".', $name));
         }
 

Command/DebugAutowiringCommand.php

@@ -87,7 +87,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 return false !== stripos(str_replace('\\', '', $serviceId), $searchNormalized) && !str_starts_with($serviceId, '.');
             });
 
-            if (empty($serviceIds)) {
+            if (!$serviceIds) {
                 $errorIo->error(sprintf('No autowirable classes or interfaces found matching "%s"', $search));
 
                 return 1;

Command/TranslationDebugCommand.php

@@ -186,7 +186,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
 
         // No defined or extracted messages
-        if (empty($allMessages) || null !== $domain && empty($allMessages[$domain])) {
+        if (!$allMessages || null !== $domain && empty($allMessages[$domain])) {
             $outputMessage = sprintf('No defined or extracted messages for locale "%s"', $locale);
 
             if (null !== $domain) {

Console/Descriptor/TextDescriptor.php

@@ -530,7 +530,7 @@ private function renderEventListenerTable(EventDispatcherInterface $eventDispatc
 
     private function formatRouterConfig(array $config): string
     {
-        if (empty($config)) {
+        if (!$config) {
             return 'NONE';
         }
 

DependencyInjection/Compiler/UnusedTagsPass.php

@@ -124,7 +124,7 @@ public function process(ContainerBuilder $container)
 
             $services = array_keys($container->findTaggedServiceIds($tag));
             $message = sprintf('Tag "%s" was defined on service(s) "%s", but was never used.', $tag, implode('", "', $services));
-            if (!empty($candidates)) {
+            if ($candidates) {
                 $message .= sprintf(' Did you mean "%s"?', implode('", "', $candidates));
             }
 

DependencyInjection/Configuration.php

@@ -350,7 +350,7 @@ private function addWorkflowSection(ArrayNodeDefinition $rootNode)
                                     $workflows = [];
                                 }
 
-                                if (1 === \count($workflows) && isset($workflows['workflows']) && !array_is_list($workflows['workflows']) && !empty(array_diff(array_keys($workflows['workflows']), ['audit_trail', 'type', 'marking_store', 'supports', 'support_strategy', 'initial_marking', 'places', 'transitions']))) {
+                                if (1 === \count($workflows) && isset($workflows['workflows']) && !array_is_list($workflows['workflows']) && array_diff(array_keys($workflows['workflows']), ['audit_trail', 'type', 'marking_store', 'supports', 'support_strategy', 'initial_marking', 'places', 'transitions'])) {
                                     $workflows = $workflows['workflows'];
                                 }