removed code for PHP < 5.3.9

Author: fabpot

Extension/Core/DataTransformer/DateTimeToStringTransformer.php

@@ -61,17 +61,13 @@ class DateTimeToStringTransformer extends BaseDateTimeTransformer
      *
      * @throws UnexpectedTypeException if a timezone is not a string
      */
-    public function __construct($inputTimezone = null, $outputTimezone = null, $format = 'Y-m-d H:i:s', $parseUsingPipe = null)
+    public function __construct($inputTimezone = null, $outputTimezone = null, $format = 'Y-m-d H:i:s', $parseUsingPipe = true)
     {
         parent::__construct($inputTimezone, $outputTimezone);
 
         $this->generateFormat = $this->parseFormat = $format;
 
-        // The pipe in the parser pattern only works as of PHP 5.3.7
-        // See http://bugs.php.net/54316
-        $this->parseUsingPipe = null === $parseUsingPipe
-            ? PHP_VERSION_ID >= 50307
-            : $parseUsingPipe;
+        $this->parseUsingPipe = $parseUsingPipe || null === $parseUsingPipe;
 
         // See http://php.net/manual/en/datetime.createfromformat.php
         // The character "|" in the format makes sure that the parts of a date

Tests/Extension/Core/DataTransformer/DateTimeToStringTransformerTest.php

@@ -57,12 +57,9 @@ public function dataProvider()
 
             // seconds since Unix
             array('U', '1265213106', '2010-02-03 16:05:06 UTC'),
-        );
 
-        // This test will fail < 5.3.9 - see https://bugs.php.net/51994
-        if (PHP_VERSION_ID >= 50309) {
-            $data[] = array('Y-z', '2010-33', '2010-02-03 00:00:00 UTC');
-        }
+            array('Y-z', '2010-33', '2010-02-03 00:00:00 UTC'),
+        );
 
         return $data;
     }
@@ -111,10 +108,6 @@ public function testTransformExpectsDateTime()
      */
     public function testReverseTransformUsingPipe($format, $input, $output)
     {
-        if (PHP_VERSION_ID < 50307) {
-            $this->markTestSkipped('Pipe usage requires PHP 5.3.7 or newer.');
-        }
-
         $reverseTransformer = new DateTimeToStringTransformer('UTC', 'UTC', $format, true);
 
         $output = new \DateTime($output);