bug #831 Shorten Symfony Recipe URL Cache Keys (cjunge-work)

This PR was merged into the 1.x branch.

Discussion
----------

Shorten Symfony Recipe URL Cache Keys

Fixes #830.

This change replaces the simple generated composer filesystem cache key with a slightly shorter one only for the Symfony Recipes repos.

`/home/cameron/.cache/composer/repo/flex/https---api.github.com-repos-symfony-recipes-contrib-contents-friendsofsymfony.elastica-bundle.5.0.json-ref-flex-main`
becomes
`/home/cameron/.cache/composer/repo/flex/sf-recipes-contrib-friendsofsymfony.elastica-bundle.5.0.json-ref-flex-main`

This won't fix other recipe files hosted on long paths.

Commits
-------

1f472eb Shorten Symfony Recipe URL Cache Keys

Author: nicolas-grekas

src/Downloader.php

@@ -271,7 +271,7 @@ private function get(array $urls, bool $isRecipe = false, int $try = 3): array
         $options = [];
 
         foreach ($urls as $url) {
-            $cacheKey = preg_replace('{[^a-z0-9.]}i', '-', $url);
+            $cacheKey = self::generateCacheKey($url);
             $headers = [];
 
             if (preg_match('{^https?://api\.github\.com/}', $url)) {
@@ -300,7 +300,7 @@ private function get(array $urls, bool $isRecipe = false, int $try = 3): array
             foreach ($urls as $url) {
                 $jobs[] = $this->rfs->add($url, $options[$url])->then(function (ComposerResponse $response) use ($url, &$responses) {
                     if (200 === $response->getStatusCode()) {
-                        $cacheKey = preg_replace('{[^a-z0-9.]}i', '-', $url);
+                        $cacheKey = self::generateCacheKey($url);
                         $responses[$url] = $this->parseJson($response->getBody(), $url, $cacheKey, $response->getHeaders())->getBody();
                     }
                 }, function (\Exception $e) use ($url, &$retries) {
@@ -314,7 +314,7 @@ private function get(array $urls, bool $isRecipe = false, int $try = 3): array
             }
             $this->rfs->download($urls, function ($url) use ($options, &$responses, &$retries, &$error) {
                 try {
-                    $cacheKey = preg_replace('{[^a-z0-9.]}i', '-', $url);
+                    $cacheKey = self::generateCacheKey($url);
                     $origin = method_exists($this->rfs, 'getOrigin') ? $this->rfs::getOrigin($url) : parse_url($url, \PHP_URL_HOST);
                     $json = $this->rfs->getContents($origin, $url, false, $options[$url]);
                     if (200 === $this->rfs->findStatusCode($this->rfs->getLastHeaders())) {
@@ -412,4 +412,11 @@ private function initialize()
             $this->endpoints[$endpoint] = $config;
         }
     }
+
+    private static function generateCacheKey(string $url): string
+    {
+        $url = preg_replace('{^https://api.github.com/repos/([^/]++/[^/]++)/contents/}', '$1/', $url);
+
+        return preg_replace('{[^a-z0-9.]}i', '-', $url);
+    }
 }