Skip to content

Expose console as a real Composer binary #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Nov 4, 2021

...and rename it to docs-builder

Copy link
Contributor

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me: we clearly state this is an internal tool, so I don't have any problem with exposing a binary. Probably the symfony.com build process will just need to update after we tag this - so FYI @javiereguiluz

@javiereguiluz
Copy link
Collaborator

I think this won't affect symfony.com because we don't use this tool via a high-level command run via Symfony's Process component (we did that in the past). Instead, we use it via low-level function calls such as:

$buildConfig = (new BuildConfig())->...();
$result = (new DocBuilder())->build($buildConfig);
if ($result->isSuccessful()) { ... } else { ... }

This is the same I'm proposing in the "doc build instructions" at symfony/symfony-docs#16068 Please, tell me what do you think about it. Thanks!

@javiereguiluz
Copy link
Collaborator

Thank you Wouter.

@javiereguiluz javiereguiluz merged commit 5493a49 into symfony-tools:main Nov 9, 2021
@wouterj wouterj deleted the binary branch November 9, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants