From 3d7d07a4a150c41559addf62575413c10f6b8a40 Mon Sep 17 00:00:00 2001
From: Wouter de Jong <wouter@wouterj.nl>
Date: Thu, 21 Oct 2021 14:11:05 +0200
Subject: [PATCH] Process sidebar directive's titles as span nodes

---
 .gitignore                                             | 1 +
 src/Directive/SidebarDirective.php                     | 2 +-
 tests/fixtures/expected/blocks/directives/sidebar.html | 3 +++
 tests/fixtures/source/blocks/directives/sidebar.rst    | 4 ++++
 4 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index ed02a52..793daca 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,3 +5,4 @@
 /docs.phar
 /.env
 /.phpunit.result.cache
+/composer.lock
diff --git a/src/Directive/SidebarDirective.php b/src/Directive/SidebarDirective.php
index 41996cf..f4674e2 100644
--- a/src/Directive/SidebarDirective.php
+++ b/src/Directive/SidebarDirective.php
@@ -25,7 +25,7 @@ public function processSub(Parser $parser, ?Node $document, string $variable, st
         $wrapperDiv = $parser->renderTemplate(
             'directives/sidebar.html.twig',
             [
-                'title' => $data,
+                'title' => $parser->createSpanNode($data)->render(),
             ]
         );
 
diff --git a/tests/fixtures/expected/blocks/directives/sidebar.html b/tests/fixtures/expected/blocks/directives/sidebar.html
index ee4a046..eba07ea 100644
--- a/tests/fixtures/expected/blocks/directives/sidebar.html
+++ b/tests/fixtures/expected/blocks/directives/sidebar.html
@@ -1,2 +1,5 @@
 <div class="admonition-wrapper"><div class="admonition admonition-sidebar"><p class="sidebar-title"><span>The sidebar's title</span></p><p>some text inside sidebar</p>
 </div></div>
+
+<div class="admonition-wrapper"><div class="admonition admonition-sidebar"><p class="sidebar-title"><span>More about the <code translate="no" class="notranslate">request()</code> Method</span></p><p>The full signature of the <code translate="no" class="notranslate">request()</code> method is...</p>
+</div></div>
diff --git a/tests/fixtures/source/blocks/directives/sidebar.rst b/tests/fixtures/source/blocks/directives/sidebar.rst
index bf10935..b179763 100644
--- a/tests/fixtures/source/blocks/directives/sidebar.rst
+++ b/tests/fixtures/source/blocks/directives/sidebar.rst
@@ -2,3 +2,7 @@
 .. sidebar:: The sidebar's title
 
     some text inside sidebar
+
+.. sidebar:: More about the ``request()`` Method
+
+    The full signature of the ``request()`` method is...