Skip to content

Commit c037e03

Browse files
committed
correcting syntax
1 parent 9db7e00 commit c037e03

File tree

3 files changed

+5
-13
lines changed

3 files changed

+5
-13
lines changed

src/Directive/GroupTabDirective.php renamed to src/Directive/TabDirective.php

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@
2020
/**
2121
* Directive that only appears within the "tabs" directive.
2222
*/
23-
class GroupTabDirective extends SubDirective
23+
class TabDirective extends SubDirective
2424
{
2525
public function getName(): string
2626
{
27-
return 'group-tab';
27+
return 'tab';
2828
}
2929

3030
public function processSub(Parser $parser, ?Node $document, string $variable, string $data, array $options): ?Node
@@ -33,15 +33,7 @@ public function processSub(Parser $parser, ?Node $document, string $variable, st
3333
if (!$tabName) {
3434
throw new \RuntimeException(sprintf('The "group-tab" directive requires a tab name: ".. group-tab:: Tab Name".'));
3535
}
36-
foreach ($document->getNodes() as $childNode) {
37-
var_dump(get_class($childNode));
38-
}
3936

4037
return new GroupTabNode($document->getNodes(), $data);
4138
}
42-
43-
private function parseGroupTabNode($groupTabNode)
44-
{
45-
46-
}
4739
}

src/KernelFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ private static function getDirectives(): array
8282
new SymfonyDirectives\DeprecatedDirective(),
8383
new SymfonyDirectives\ErrorDirective(),
8484
new SymfonyDirectives\FigureDirective(),
85-
new SymfonyDirectives\GroupTabDirective(),
8685
new SymfonyDirectives\HintDirective(),
8786
new SymfonyDirectives\ImportantDirective(),
8887
new SymfonyDirectives\IndexDirective(),
@@ -92,6 +91,7 @@ private static function getDirectives(): array
9291
new SymfonyDirectives\ScreencastDirective(),
9392
new SymfonyDirectives\SeeAlsoDirective(),
9493
new SymfonyDirectives\SidebarDirective(),
94+
new SymfonyDirectives\TabDirective(),
9595
new SymfonyDirectives\TabsDirective(),
9696
new SymfonyDirectives\TipDirective(),
9797
new SymfonyDirectives\TopicDirective(),

tests/fixtures/source/blocks/directives/tabs.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11

22
.. tabs:: UX Installation
33

4-
.. group-tab:: Webpack Encore
4+
.. tab:: Webpack Encore
55

66
Webpack Encore stuff!
77

88
.. code-block:: yaml
99
1010
I am yaml:
1111
12-
.. group-tab:: AssetMapper
12+
.. tab:: AssetMapper
1313

1414
AssetMapper stuff!
1515

0 commit comments

Comments
 (0)