Skip to content

Commit a14f15a

Browse files
committed
minor #185 Fix PHP 8.4 deprecations (javiereguiluz)
This PR was merged into the main branch. Discussion ---------- Fix PHP 8.4 deprecations It fixes this: ``` SymfonyDocsBuilder\SymfonyHTMLFormat::__construct(): Implicitly marking parameter $symfonyVersion as nullable is deprecated, the explicit nullable type must be used instead SymfonyDocsBuilder\Renderers\SpanNodeRenderer::__construct(): Implicitly marking parameter $symfonyVersion as nullable is deprecated, the explicit nullable type must be used instead ``` Commits ------- d05cf42 Fix PHP 8.4 deprecations
2 parents 29ddf17 + d05cf42 commit a14f15a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/Renderers/SpanNodeRenderer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function __construct(
3232
SpanNode $span,
3333
BaseSpanNodeRenderer $decoratedSpanNodeRenderer,
3434
?UrlChecker $urlChecker = null,
35-
string $symfonyVersion = null
35+
?string $symfonyVersion = null
3636
)
3737
{
3838
parent::__construct($environment, $span);

src/SymfonyHTMLFormat.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ final class SymfonyHTMLFormat implements Format
2929
private $urlChecker;
3030
private $symfonyVersion;
3131

32-
public function __construct(TemplateRenderer $templateRenderer, Format $HTMLFormat, ?UrlChecker $urlChecker = null, string $symfonyVersion = null)
32+
public function __construct(TemplateRenderer $templateRenderer, Format $HTMLFormat, ?UrlChecker $urlChecker = null, ?string $symfonyVersion = null)
3333
{
3434
$this->templateRenderer = $templateRenderer;
3535
$this->htmlFormat = $HTMLFormat;

0 commit comments

Comments
 (0)