Skip to content

Commit 5363271

Browse files
committed
minor #121 Add a failing test about titles using non-Latin scripts (javiereguiluz)
This PR was squashed before being merged into the main branch. Discussion ---------- Add a failing test about titles using non-Latin scripts Title says it all. The problem is in this line: https://github.com/doctrine/rst-parser/blob/35c61ece3a209a742f9382a4b4f5680365979750/lib/Environment.php#L492 ``` iconv(): Detected an illegal character in input string vendor/doctrine/rst-parser/lib/Environment.php:492 vendor/doctrine/rst-parser/lib/Nodes/TitleNode.php:32 vendor/doctrine/rst-parser/lib/NodeFactory/NodeInstantiator.php:71 vendor/doctrine/rst-parser/lib/NodeFactory/DefaultNodeFactory.php:272 vendor/doctrine/rst-parser/lib/NodeFactory/DefaultNodeFactory.php:83 vendor/doctrine/rst-parser/lib/Parser/DocumentParser.php:481 vendor/doctrine/rst-parser/lib/Parser/DocumentParser.php:395 vendor/doctrine/rst-parser/lib/Parser/DocumentParser.php:212 vendor/doctrine/rst-parser/lib/Parser/DocumentParser.php:149 vendor/doctrine/rst-parser/lib/Parser.php:178 vendor/doctrine/rst-parser/lib/Parser.php:162 vendor/doctrine/rst-parser/lib/Parser.php:200 tests/IntegrationTest.php:99 ``` Should I create a PR in Doctrine RST parser to add Symfony String as a dependency and slugify strings with it? Commits ------- 8fe50b1 Add a failing test about titles using non-Latin scripts
2 parents 09ea5cc + 8fe50b1 commit 5363271

File tree

5 files changed

+39
-1803
lines changed

5 files changed

+39
-1803
lines changed

composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
}
1515
},
1616
"require": {
17+
"php": "^7.2 || ^8.0",
1718
"ext-json": "*",
1819
"ext-curl": "*",
1920
"doctrine/rst-parser": "^0.4",

0 commit comments

Comments
 (0)