Skip to content

Commit 22d0822

Browse files
committed
minor #124 Add a failing test about diff code highlighting (javiereguiluz)
This PR was squashed before being merged into the main branch. Discussion ---------- Add a failing test about diff code highlighting `@wouterj` reported that a code block here https://symfony.com/doc/current/security.html#form-login didn't show any highlighting. It's true. The problem occurs when a `diff` code block doesn't start its first line with `+` or `-` In this failing test, the first code block works but the second doesn't ~(to be completely honest, the first one doesn't work either because of some white space issue which I can't see, but it mostly works)~ <-- this problem was fixed by Ryan. Thanks! Commits ------- ac48cde Add a failing test about diff code highlighting
2 parents ea6cedd + ac48cde commit 22d0822

File tree

3 files changed

+61
-0
lines changed

3 files changed

+61
-0
lines changed

tests/IntegrationTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,10 @@ public function parserUnitBlockProvider()
260260
'blockName' => 'code-blocks/bash',
261261
];
262262

263+
yield 'code-block-diff' => [
264+
'blockName' => 'code-blocks/diff',
265+
];
266+
263267
yield 'code-block-html-php' => [
264268
'blockName' => 'code-blocks/html-php',
265269
];
Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
<div translate="no" data-loc="5" class="notranslate codeblock codeblock-length-sm codeblock-diff">
2+
<div class="codeblock-scroll">
3+
<pre class="codeblock-lines">1
4+
2
5+
3
6+
4
7+
5</pre>
8+
<pre class="codeblock-code">
9+
<code>
10+
<span class="hljs-addition">+ Added line</span>
11+
<span class="hljs-deletion">- Removed line</span>
12+
Normal line
13+
<span class="hljs-deletion">- Removed line</span>
14+
<span class="hljs-addition">+ Added line</span>
15+
</code>
16+
</pre>
17+
</div>
18+
</div>
19+
20+
<div translate="no" data-loc="6" class="notranslate codeblock codeblock-length-sm codeblock-diff">
21+
<div class="codeblock-scroll">
22+
<pre class="codeblock-lines">1
23+
2
24+
3
25+
4
26+
5
27+
6</pre>
28+
<pre class="codeblock-code">
29+
<code>
30+
Normal line
31+
<span class="hljs-addition">+ Added line</span>
32+
<span class="hljs-deletion">- Removed line</span>
33+
Normal line
34+
<span class="hljs-deletion">- Removed line</span>
35+
<span class="hljs-addition">+ Added line</span>
36+
</code>
37+
</pre>
38+
</div>
39+
</div>
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
2+
.. code-block:: diff
3+
4+
+ Added line
5+
- Removed line
6+
Normal line
7+
- Removed line
8+
+ Added line
9+
10+
11+
.. code-block:: diff
12+
13+
Normal line
14+
+ Added line
15+
- Removed line
16+
Normal line
17+
- Removed line
18+
+ Added line

0 commit comments

Comments
 (0)