Skip to content

Commit c3f801b

Browse files
authored
Merge pull request swiftlang#33878 from varungandhi-apple/vg-doc-address-review-comments
2 parents b5252eb + 23b65ed commit c3f801b

File tree

4 files changed

+15
-7
lines changed

4 files changed

+15
-7
lines changed

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ If you are interested in:
8080
up until the "Building the project" section. After that, follow the
8181
instructions in the [Swift Toolchains](#swift-toolchains) section below.
8282

83+
We also have an [FAQ](/docs/HowToGuides/FAQ.md) that answers common questions.
84+
8385
[Getting Started guide]: /docs/HowToGuides/GettingStarted.md
8486

8587
### Swift Toolchains
@@ -143,14 +145,14 @@ Try the suggestions in
143145
[Troubleshooting build issues](/docs/HowToGuides/GettingStarted.md#troubleshooting-build-issues).
144146

145147
Make sure you are using the
146-
[correct release](/docs/HowToGuides/GettingStared.md#installing-dependencies)
148+
[correct release](/docs/HowToGuides/GettingStarted.md#installing-dependencies)
147149
of Xcode.
148150

149151
If you have changed Xcode versions but still encounter errors that appear to
150152
be related to the Xcode version, try passing `--clean` to `build-script`.
151153

152154
When a new version of Xcode is released, you can update your build without
153-
recompiling the entire project by passing the `--reconfigure` option.
155+
recompiling the entire project by passing `--reconfigure` to `build-script`.
154156

155157
## Learning More
156158

docs/HowToGuides/FAQ.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,14 @@ This very depends on what X is, but some broad guidelines are:
6464
1. Do a case-insensitive recursive string search.
6565
- Use a specialized tool like [ripgrep](https://github.com/BurntSushi/ripgrep)
6666
or [ag](https://github.com/ggreer/the_silver_searcher).
67+
- Use `git grep --ignore-case "mypattern"`. `git grep` also supports helpful
68+
flags which provide more context:
69+
- `--show-function`: Tries to print the function name that a match was
70+
found in.
71+
- `--function-context`: Tries to print the entire surrounding function
72+
containing the match.
6773
- Use 'Find in Workspace' in Xcode (<kbd>⌘</kbd>+<kbd>⇧</kbd>+<kbd>F</kbd>).
68-
- Use `grep -i -r "mypattern" .`.
74+
- Use `grep --ignore-case --recursive "mypattern" .`.
6975
2. Go through the [Documentation Index](/docs/README.md).
7076

7177
### How do I build the documentation as HTML?

docs/HowToGuides/FirstPullRequest.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ you are an experienced open source contributor who is excited about Swift, or
66
maybe you are somewhere in-between. Regardless of your background, we are
77
excited to have you contribute and improve the developer experience for Swift
88
programmers all over the globe.
9-
:sparkles::child::student::woman_technologist::technologist::man_technologist::sparkles:
9+
:sparkles:🧒🏾🧑🏼‍🎓👩🏽‍💻🧑🏻‍💻👨🏿‍💻:sparkles:
1010

1111
This document provides a high-level overview of different parts of the
1212
contribution process.

docs/HowToGuides/GettingStarted.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ toolchain as a one-off, there are a couple of differences:
1919
- [Ubuntu Linux](#ubuntu-linux)
2020
- [Building the project for the first time](#building-the-project-for-the-first-time)
2121
- [Spot check dependencies](#spot-check-dependencies)
22-
- [Understanding the pieces](#understanding-the-pieces)
22+
- [The roles of different tools](#the-roles-of-different-tools)
2323
- [The actual build](#the-actual-build)
2424
- [Troubleshooting build issues](#troubleshooting-build-issues)
2525
- [Editing code](#editing-code)
@@ -373,7 +373,7 @@ The codebase is your oyster!
373373
374374
Now that you have made some changes, you will need to rebuild...
375375
376-
### Incremental rebuilds with Ninja
376+
### Incremental builds with Ninja
377377
378378
To rebuild the compiler:
379379
```sh
@@ -503,7 +503,7 @@ utils/build-script --release-debuginfo --debug-swift # other flags...
503503
# debug Stdlib + optimized Swiftc + optimized Clang/LLVM
504504
utils/build-script --release-debuginfo --debug-swift-stdlib # other flags...
505505
506-
# optimized Stdlib + debug Swiftc (expect typechecker) + optimized Clang/LLVM
506+
# optimized Stdlib + debug Swiftc (except typechecker) + optimized Clang/LLVM
507507
utils/build-script --release-debuginfo --debug-swift --force-optimized-typechecker
508508
509509
# Last resort option, it is highly unlikely that you will need this

0 commit comments

Comments
 (0)