Start migrating imported functions to the new definition style

Use of different function names for C-name and Wasm's import name is a
bit confusing. Also use of unprefixed function names in the C code is
not a good practice. This commit starts migrating imported functions to
the new naming convention and removes duplicated function definitions
just for IDE support by using macro.

Author: kateinoigakukun

Sources/JavaScriptKit/JSValue.swift

@@ -206,7 +206,7 @@ public func getJSValue(this: JSObject, name: JSString) -> JSValue {
 
 public func setJSValue(this: JSObject, name: JSString, value: JSValue) {
     value.withRawJSValue { rawValue in
-        _set_prop(this.id, name.asInternalJSRef(), rawValue.kind, rawValue.payload1, rawValue.payload2)
+        swjs_set_prop(this.id, name.asInternalJSRef(), rawValue.kind, rawValue.payload1, rawValue.payload2)
     }
 }
 
@@ -240,7 +240,7 @@ public func getJSValue(this: JSObject, symbol: JSSymbol) -> JSValue {
 
 public func setJSValue(this: JSObject, symbol: JSSymbol, value: JSValue) {
     value.withRawJSValue { rawValue in
-        _set_prop(this.id, symbol.id, rawValue.kind, rawValue.payload1, rawValue.payload2)
+        swjs_set_prop(this.id, symbol.id, rawValue.kind, rawValue.payload1, rawValue.payload2)
     }
 }
 

Sources/JavaScriptKit/XcodeSupport.swift

@@ -6,13 +6,6 @@ import _CJavaScriptKit
 /// to be built for host platforms like macOS or Linux for tentative IDE support.
 /// (ideally, IDE should build for WebAssembly target though)
 #if !arch(wasm32)
-    func _set_prop(
-        _: JavaScriptObjectRef,
-        _: JavaScriptObjectRef,
-        _: JavaScriptValueKind,
-        _: JavaScriptPayload1,
-        _: JavaScriptPayload2
-    ) { fatalError() }
     func _get_prop(
         _: JavaScriptObjectRef,
         _: JavaScriptObjectRef,

Sources/_CJavaScriptKit/include/_CJavaScriptKit.h

@@ -73,21 +73,29 @@ typedef struct {
 } RawJSValue;
 
 #if __wasm32__
+# define IMPORT_JS_FUNCTION(name, returns, args) \
+__attribute__((__import_module__("javascript_kit"), __import_name__(#name))) extern returns name args;
+#else
+# define IMPORT_JS_FUNCTION(name, returns, args) \
+  static inline returns name args { \
+    abort(); \
+  }
+#endif
 
-/// `_set_prop` sets a value of `_this` JavaScript object.
+/// Set a value of `_this` JavaScript object.
 ///
 /// @param _this The target JavaScript object to set the given value.
 /// @param prop A JavaScript string object to reference a member of `_this` object.
 /// @param kind A kind of JavaScript value to set the target object.
 /// @param payload1 The first payload of JavaScript value to set the target object.
 /// @param payload2 The second payload of JavaScript value to set the target object.
-__attribute__((__import_module__("javascript_kit"),
-               __import_name__("swjs_set_prop")))
-extern void _set_prop(const JavaScriptObjectRef _this,
-                      const JavaScriptObjectRef prop,
-                      const JavaScriptValueKind kind,
-                      const JavaScriptPayload1 payload1,
-                      const JavaScriptPayload2 payload2);
+IMPORT_JS_FUNCTION(swjs_set_prop, void, (const JavaScriptObjectRef _this,
+                                         const JavaScriptObjectRef prop,
+                                         const JavaScriptValueKind kind,
+                                         const JavaScriptPayload1 payload1,
+                                         const JavaScriptPayload2 payload2))
+
+#if __wasm32__
 
 /// `_get_prop` gets a value of `_this` JavaScript object.
 ///