Prefer UInt(bitPattern:) for object id to guarantee uniqueness

Close #218

Author: kateinoigakukun

Runtime/src/index.ts

@@ -14,7 +14,7 @@ export class SwiftRuntime {
     private _instance: WebAssembly.Instance | null;
     private _memory: Memory | null;
     private _closureDeallocator: SwiftClosureDeallocator | null;
-    private version: number = 708;
+    private version: number = 709;
 
     private textDecoder = new TextDecoder("utf-8");
     private textEncoder = new TextEncoder(); // Only support utf-8

Sources/JavaScriptKit/FundamentalObjects/JSClosure.swift

@@ -20,7 +20,7 @@ public class JSOneshotClosure: JSObject, JSClosureProtocol {
         super.init(id: 0)
 
         // 2. Create a new JavaScript function which calls the given Swift function.
-        hostFuncRef = JavaScriptHostFuncRef(bitPattern: Int32(ObjectIdentifier(self).hashValue))
+        hostFuncRef = JavaScriptHostFuncRef(bitPattern: ObjectIdentifier(self))
         id = withExtendedLifetime(JSString(file)) { file in
           _create_function(hostFuncRef, line, file.asInternalJSRef())
         }
@@ -86,7 +86,7 @@ public class JSClosure: JSObject, JSClosureProtocol {
         super.init(id: 0)
 
         // 2. Create a new JavaScript function which calls the given Swift function.
-        hostFuncRef = JavaScriptHostFuncRef(bitPattern: Int32(ObjectIdentifier(self).hashValue))
+        hostFuncRef = JavaScriptHostFuncRef(bitPattern: ObjectIdentifier(self))
         id = withExtendedLifetime(JSString(file)) { file in
           _create_function(hostFuncRef, line, file.asInternalJSRef())
         }

Sources/_CJavaScriptKit/_CJavaScriptKit.c

@@ -37,7 +37,7 @@ void swjs_cleanup_host_function_call(void *argv_buffer) {
 /// this and `SwiftRuntime.version` in `./Runtime/src/index.ts`.
 __attribute__((export_name("swjs_library_version")))
 int swjs_library_version(void) {
-    return 708;
+    return 709;
 }
 
 int _library_features(void);

Sources/_CJavaScriptKit/include/_CJavaScriptKit.h

@@ -10,7 +10,7 @@
 typedef unsigned int JavaScriptObjectRef;
 /// `JavaScriptHostFuncRef` represents Swift closure that is referenced by JavaScript side.
 /// This value is produced by `JSClosure`.
-typedef unsigned int JavaScriptHostFuncRef;
+typedef uintptr_t JavaScriptHostFuncRef;
 
 /// `JavaScriptValueKind` represents the kind of JavaScript primitive value.
 typedef enum __attribute__((enum_extensibility(closed))) {