Concurrency: Guard TG state with a mutex even with cooperative executor #75008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SWIFT_STDLIB_SINGLE_THREADED_CONCURRENCY` just means that the global executor is cooperative, but it doesn't mean that the target platform is always single-threaded. For example, on wasm32-unknown-wasip1-threads, the global executor is cooperative, but users can still set up their own TaskExecutor with multiple threads. This patch guards the `TaskGroup` state with a mutex even with a cooperative executor by respecting threading package instead. This change effectively affects only wasm32-unknown-wasip1-threads.
|
@swift-ci smoke test |
|
@swift-ci test WebAssembly |
ktoso
reviewed
Jul 8, 2024
ktoso
added
the
concurrency
|
I added your comment in the PR as a source comment, keeping track of the "why" of those #if is very tricky so we need to document such in source IMHO, pending some other improved refactoring of the runtime that would make this less difficult to manage/understand. LGTM though, merging |
ktoso
approved these changes
Jul 8, 2024
|
@kateinoigakukun do we want this on 6.0 as well? If so please prepare a PR and ping me :) |
|
Thanks! Yes, we need this in 6.0 too |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT_STDLIB_SINGLE_THREADED_CONCURRENCYjust means that the global executor is cooperative, but it doesn't mean that the target platform is always single-threaded. For example, on wasm32-unknown-wasip1-threads, the global executor is cooperative, but users can still set up their own TaskExecutor with multiple threads.This patch guards the
TaskGroupstate with a mutex even with a cooperative executor by respecting threading package instead. This change effectively affects only wasm32-unknown-wasip1-threads.