Skip to content

Commit 5b062fb

Browse files
committed
[swift-syntax] Reduce number of jobs that verify generated files
We were checking that the generated files matched the code in CodeGeneration in a number of jobs, which was still a relict from when `gyb_syntax_support` lived in the swift repo and was thus possible to break with a PR to the swift repo. Now, CodeGeneration lives exclusively in the swift-syntax repo and thus the checked in generated files can only be broken by a swift-syntax change. Reduce the number of jobs that verify the generated files to: - swift-syntax macOS PR testing (no need to run CodeGeneration on macOS and Linux) - `buildbot_all_platforms,tools=RA,stdlib=RA`, which is used fro the macOS Pull Request status bot so we get signal if two PRs in swift-syntax raced and broke the checked in generated files And while at it, also only verify the formatting of swift-syntax on macOS. There’s no need to verify it on all platforms.
1 parent 3a05e79 commit 5b062fb

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

utils/build-presets.ini

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,6 @@ sourcekit-lsp
371371
# Failing to build in CI: rdar://78408440
372372
# swift-inspect
373373
swiftsyntax
374-
swiftsyntax-verify-generated-files
375374
swiftformat
376375

377376
skstresstester
@@ -631,7 +630,6 @@ libcxx
631630
llbuild
632631
swiftpm
633632
swiftsyntax
634-
swiftsyntax-verify-generated-files
635633
swiftformat
636634
swift-driver
637635
indexstore-db
@@ -1160,7 +1158,6 @@ xctest
11601158
foundation
11611159
libdispatch
11621160
swiftsyntax
1163-
swiftsyntax-verify-generated-files
11641161
swiftformat
11651162
indexstore-db
11661163
sourcekit-lsp
@@ -1304,10 +1301,6 @@ indexstore-db
13041301
sourcekit-lsp
13051302
swiftdocc
13061303

1307-
# Don't generate the SwiftSyntax gyb files. Instead verify that up-to-date ones
1308-
# are checked in.
1309-
swiftsyntax-verify-generated-files
1310-
13111304
# Build with debug info, this allows us to symbolicate crashes from
13121305
# production builds.
13131306
release-debuginfo
@@ -1905,8 +1898,6 @@ assertions
19051898
swiftsyntax
19061899
swiftsyntax-enable-rawsyntax-validation
19071900
swiftsyntax-enable-test-fuzzing
1908-
swiftsyntax-verify-generated-files
1909-
swiftsyntax-lint
19101901
sourcekit-lsp
19111902
swiftformat
19121903

0 commit comments

Comments
 (0)