Improve the compatibility layer a little bit more

There were some typos in the compatibility layer and some properties didn’t have setters.

Author: ahoppen

CodeGeneration/Sources/SyntaxSupport/SyntaxNodeKind.swift

@@ -416,7 +416,7 @@ public enum SyntaxNodeKind: String, CaseIterable {
     case .packElementType: return "packReferenceType"
     case .patternExpr: return "unresolvedPatternExpr"
     case .platformVersion: return "availabilityVersionRestriction"
-    case .platformVersionItem: return " availabilityVersionRestrictionListEntry"
+    case .platformVersionItem: return "availabilityVersionRestrictionListEntry"
     case .platformVersionItemList: return "availabilityVersionRestrictionList"
     case .postfixOperatorExpr: return "postfixUnaryExpr"
     case .poundSourceLocationArguments: return "poundSourceLocationArgs"

Sources/SwiftSyntax/SwiftSyntaxCompatibility.swift

@@ -21,6 +21,11 @@ extension AttributeSyntax {
 @available(*, deprecated, renamed: "WithAttributesSyntax")
 public typealias AttributedSyntax = WithAttributesSyntax
 
+extension AvailabilityArgumentSyntax {
+  @available(*, deprecated, renamed: "Argument")
+  public typealias Entry = Argument
+}
+
 extension ClosureSignatureSyntax {
   @available(*, deprecated, renamed: "ParameterClause")
   public typealias Input = ParameterClause
@@ -80,12 +85,22 @@ extension NamedDeclSyntax {
 extension MemberAccessExprSyntax {
   @available(*, deprecated, renamed: "declName.baseName")
   public var name: TokenSyntax {
-    return declName.baseName
+    get {
+      return declName.baseName
+    }
+    set {
+      declName.baseName = newValue
+    }
   }
 
   @available(*, deprecated, renamed: "declName.argumentNames")
   public var declNameArguments: DeclNameArgumentsSyntax? {
-    return declName.argumentNames
+    get {
+      return declName.argumentNames
+    }
+    set {
+      declName.argumentNames = newValue
+    }
   }
 
   @available(*, deprecated, message: "Use initializer taking `DeclReferenceExprSyntax` instead")
@@ -245,7 +260,7 @@ public extension TokenSyntax {
   }
 
   @available(*, deprecated, renamed: "poundElseifToken")
-  static func poundElseIfKeyword(
+  static func poundElseifKeyword(
     leadingTrivia: Trivia = [],
     trailingTrivia: Trivia = [],
     presence: SourcePresence = .present

Sources/SwiftSyntax/generated/RenamedNodesCompatibility.swift

@@ -12,9 +12,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-@available(*, deprecated, renamed: "PlatformVersionItemSyntax")
-public typealias  availabilityVersionRestrictionListEntrySyntax = PlatformVersionItemSyntax
-
 @available(*, deprecated, renamed: "ImportPathComponentListSyntax")
 public typealias AccessPathSyntax = ImportPathComponentListSyntax
 
@@ -42,6 +39,9 @@ public typealias AvailabilityVersionRestrictionSyntax = PlatformVersionSyntax
 @available(*, deprecated, renamed: "PlatformVersionItemListSyntax")
 public typealias AvailabilityVersionRestrictionListSyntax = PlatformVersionItemListSyntax
 
+@available(*, deprecated, renamed: "PlatformVersionItemSyntax")
+public typealias AvailabilityVersionRestrictionListEntrySyntax = PlatformVersionItemSyntax
+
 @available(*, deprecated, renamed: "BackDeployedAttributeArgumentsSyntax")
 public typealias BackDeployedAttributeSpecListSyntax = BackDeployedAttributeArgumentsSyntax
 
@@ -211,10 +211,6 @@ public typealias YieldExprListElementSyntax = YieldedExpressionSyntax
 public typealias YieldListSyntax = YieldedExpressionsClauseSyntax
 
 public extension SyntaxKind {
-  static var  availabilityVersionRestrictionListEntry: Self {
-    return .platformVersionItem
-  }
-  
   static var accessPath: Self {
     return .importPathComponentList
   }
@@ -251,6 +247,10 @@ public extension SyntaxKind {
     return .platformVersionItemList
   }
 
+  static var availabilityVersionRestrictionListEntry: Self {
+    return .platformVersionItem
+  }
+  
   static var backDeployedAttributeSpecList: Self {
     return .backDeployedAttributeArguments
   }