Bring back the convenience initializer and deprecate it. Add entries to release notes.

Author: MAJKFL

Release Notes/601.md

@@ -14,6 +14,10 @@
 - `Error` protocol now has an `asDiagnostics(at:)` method.
   - Description: This method translates an error into one or more diagnostics, recognizing `DiagnosticsError` and `DiagnosticMessage` instances or providing its own `Diagnostic` as needed.
   - Pull Request: https://github.com/swiftlang/swift-syntax/pull/1816
+  
+- `ClosureCaptureSyntax` now has a new node structure.
+  - Description: `ClosureCaptureSyntax` now has an `initializer` property instead of `equal` and `expression`. Additionally, the `name` property is no longer optional.
+  - Pull request: https://github.com/swiftlang/swift-syntax/pull/2763
 
 ## API Behavior Changes
 
@@ -27,6 +31,10 @@
   - Description: `IncrementalEdit` is being dropped for `SourceEdit`. `SourceEdit` has deprecated compatibility layers to make it API-compatible with `IncrementalEdit`
   - Issue: https://github.com/apple/swift-syntax/issues/2532
   - Pull request: https://github.com/apple/swift-syntax/pull/2604
+  
+- `ClosureCaptureSyntax.init(leadingTrivia:specifier:name:equal:expression:trailingComma:trailingTrivia:)` deprecated in favor of a new `ClosureCaptureSyntax.init(leadingTrivia:_:specifier:_:name:_:initializer:_:trailingComma:_:trailingTrivia:)` initializer.
+  - Description: The change is due to a new `ClosureCaptureSyntax` node structure.
+  - Pull request: https://github.com/swiftlang/swift-syntax/pull/2763 
 
 ## API-Incompatible Changes
 

Sources/SwiftParser/Expressions.swift

@@ -1705,26 +1705,20 @@ extension Parser {
 
           // The thing being capture specified is an identifier, or as an identifier
           // followed by an initializer clause.
-          let unexpectedBeforeName: RawUnexpectedNodesSyntax?
-          let name: RawTokenSyntax
+          let (unexpectedBeforeName, name) = self.expect(
+            .identifier,
+            TokenSpec(.self),
+            default: .identifier
+          )
+
           let initializer: RawInitializerClauseSyntax?
-          if self.peek(isAt: .equal) {
+          if self.at(.equal) {
             // The name is a new declaration with
             // initializer clause.
-            (unexpectedBeforeName, name) = self.expect(
-              .identifier,
-              TokenSpec(.self, remapping: .identifier),
-              default: .identifier
-            )
             initializer = self.parseInitializerClause()
           } else {
             // This is the simple case - the identifier is the name and
             // the initializer clause is empty.
-            (unexpectedBeforeName, name) = self.expect(
-              .identifier,
-              TokenSpec(.self),
-              default: .identifier
-            )
             initializer = nil
           }
 

Sources/SwiftSyntax/Convenience.swift

@@ -10,6 +10,37 @@
 //
 //===----------------------------------------------------------------------===//
 
+extension ClosureCaptureSyntax {
+
+  /// Creates a ``ClosureCaptureSyntax`` with a `name`, and automatically adds an `equal` token to it since the name is non-optional.
+  ///
+  /// - SeeAlso: ``ClosureCaptureSyntax/init(leadingTrivia:_:specifier:_:name:_:initializer:_:trailingComma:_:trailingTrivia:)``.
+  ///
+  @available(
+    *,
+    deprecated,
+    message: "Use 'init(leadingTrivia:_:specifier:_:name:_:initializer:_:trailingComma:_:trailingTrivia:)' instead"
+  )
+  public init(
+    leadingTrivia: Trivia? = nil,
+    specifier: ClosureCaptureSpecifierSyntax? = nil,
+    name: TokenSyntax,
+    equal: TokenSyntax = TokenSyntax.equalToken(),
+    expression: some ExprSyntaxProtocol,
+    trailingComma: TokenSyntax? = nil,
+    trailingTrivia: Trivia? = nil
+  ) {
+    self.init(
+      leadingTrivia: leadingTrivia,
+      specifier: specifier,
+      name: name,
+      initializer: InitializerClauseSyntax(equal: equal, value: expression),
+      trailingComma: trailingComma,
+      trailingTrivia: trailingTrivia
+    )
+  }
+}
+
 extension EnumCaseParameterSyntax {
 
   /// Creates an ``EnumCaseParameterSyntax`` with a `firstName`, and automatically adds a `colon` to it.