Follow up of #2564

Author: meg-gupta

CodeGeneration/Sources/SyntaxSupport/TypeNodes.swift

@@ -570,14 +570,11 @@ public let TYPE_NODES: [Node] = [
     experimentalFeature: .nonescapableTypes,
     nameForDiagnostics: "lifetime specifier",
     documentation: "A specifier that specifies function parameter on whose lifetime a type depends",
-    traits: [
-      "Parenthesized"
-    ],
     children: [
       Child(
         name: "dependsOnKeyword",
         kind: .token(choices: [.keyword(.dependsOn)]),
-        documentation: "The specifier token that's attached to the type."
+        documentation: "lifetime dependence specifier on the return type"
       ),
       Child(
         name: "leftParen",
@@ -586,6 +583,7 @@ public let TYPE_NODES: [Node] = [
       Child(
         name: "scopedKeyword",
         kind: .token(choices: [.keyword(.scoped)]),
+        documentation: "scoped lifetime dependence specifier",
         isOptional: true
       ),
       Child(

Sources/SwiftParser/Types.swift

@@ -901,7 +901,7 @@ extension Parser.Lookahead {
 
 extension Parser {
   private mutating func parseLifetimeTypeSpecifier() -> RawTypeSpecifierListSyntax.Element {
-    let specifier = self.eat(TokenSpec(.dependsOn))
+    let (unexpectedBeforeDependsOnKeyword, dependsOnKeyword) = self.expect(.keyword(.dependsOn))
 
     guard let leftParen = self.consume(if: .leftParen) else {
       // If there is no left paren, add an entirely missing detail. Otherwise, we start to consume the following type
@@ -916,7 +916,8 @@ extension Parser {
         arena: self.arena
       )
       let lifetimeSpecifier = RawLifetimeTypeSpecifierSyntax(
-        dependsOnKeyword: specifier,
+        unexpectedBeforeDependsOnKeyword,
+        dependsOnKeyword: dependsOnKeyword,
         leftParen: missingToken(.leftParen),
         scopedKeyword: nil,
         arguments: arguments,
@@ -952,7 +953,8 @@ extension Parser {
       arena: self.arena
     )
     let lifetimeSpecifier = RawLifetimeTypeSpecifierSyntax(
-      dependsOnKeyword: specifier,
+      unexpectedBeforeDependsOnKeyword,
+      dependsOnKeyword: dependsOnKeyword,
       leftParen: leftParen,
       scopedKeyword: scoped,
       arguments: argumentsSyntax,
@@ -981,7 +983,7 @@ extension Parser {
     SPECIFIER_PARSING: while canHaveParameterSpecifier {
       if let (_, specifierHandle) = self.at(anyIn: SimpleTypeSpecifierSyntax.SpecifierOptions.self) {
         specifiers.append(parseSimpleTypeSpecifier(specifierHandle: specifierHandle))
-      } else if self.at(TokenSpec(.dependsOn)) {
+      } else if self.at(.keyword(.dependsOn)) {
         if self.experimentalFeatures.contains(.nonescapableTypes) {
           specifiers.append(parseLifetimeTypeSpecifier())
         } else {

Sources/SwiftSyntax/generated/SyntaxTraits.swift

@@ -779,8 +779,6 @@ extension LabeledSpecializeArgumentSyntax: WithTrailingCommaSyntax {}
 
 extension LifetimeSpecifierArgumentSyntax: WithTrailingCommaSyntax {}
 
-extension LifetimeTypeSpecifierSyntax: ParenthesizedSyntax {}
-
 extension MacroDeclSyntax: NamedDeclSyntax, WithAttributesSyntax, WithGenericParametersSyntax, WithModifiersSyntax {}
 
 extension MacroExpansionDeclSyntax: FreestandingMacroExpansionSyntax, WithAttributesSyntax, WithModifiersSyntax {}

Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesJKLMN.swift

@@ -1935,7 +1935,8 @@ public struct LifetimeTypeSpecifierSyntax: SyntaxProtocol, SyntaxHashable, _Leaf
 
   /// - Parameters:
   ///   - leadingTrivia: Trivia to be prepended to the leading trivia of the node’s first token. If the node is empty, there is no token to attach the trivia to and the parameter is ignored.
-  ///   - dependsOnKeyword: The specifier token that's attached to the type.
+  ///   - dependsOnKeyword: lifetime dependence specifier on the return type
+  ///   - scopedKeyword: scoped lifetime dependence specifier
   ///   - trailingTrivia: Trivia to be appended to the trailing trivia of the node’s last token. If the node is empty, there is no token to attach the trivia to and the parameter is ignored.
   public init(
       leadingTrivia: Trivia? = nil,
@@ -2002,7 +2003,7 @@ public struct LifetimeTypeSpecifierSyntax: SyntaxProtocol, SyntaxHashable, _Leaf
     }
   }
 
-  /// The specifier token that's attached to the type.
+  /// lifetime dependence specifier on the return type
   ///
   /// ### Tokens
   /// 
@@ -2046,6 +2047,8 @@ public struct LifetimeTypeSpecifierSyntax: SyntaxProtocol, SyntaxHashable, _Leaf
     }
   }
 
+  /// scoped lifetime dependence specifier
+  ///
   /// ### Tokens
   /// 
   /// For syntax trees generated by the parser, this is guaranteed to be `scoped`.