Replace startsOnNewline(_:) with a computed property added as a private extension to SyntaxProtocol in CodeGenerationFormat

Author: roopekv

CodeGeneration/Sources/Utils/CodeGenerationFormat.swift

@@ -97,14 +97,8 @@ public class CodeGenerationFormat: BasicFormat {
     // Short tuple element list literals are presented on one line, list each element on a different line.
     if children.count > maxElementsOnSameLine {
       let inMethodCallThatStartsOnNewline =
-        if let functionCallExpr = node.parent?.as(FunctionCallExprSyntax.self),
-          let memberAccessExpr = functionCallExpr.calledExpression.as(MemberAccessExprSyntax.self),
-          startsOnNewline(memberAccessExpr.period)
-        {
-          true
-        } else {
-          false
-        }
+        node.parent?.as(FunctionCallExprSyntax.self)?.calledExpression.as(MemberAccessExprSyntax.self)?.period
+        .startsOnNewline ?? false
       if inMethodCallThatStartsOnNewline {
         increaseIndentationLevel()
       }
@@ -129,7 +123,7 @@ public class CodeGenerationFormat: BasicFormat {
       if indentManually {
         return false
       }
-      if !startsOnNewline(node) {
+      if !node.startsOnNewline {
         return false
       }
     default:
@@ -166,7 +160,7 @@ public class CodeGenerationFormat: BasicFormat {
       var child = child
       child.trailingTrivia = Trivia(pieces: child.trailingTrivia.drop(while: \.isSpaceOrTab))
 
-      if !startsOnNewline(child) {
+      if !child.startsOnNewline {
         child.leadingTrivia = indentedNewline + child.leadingTrivia
       }
       return child
@@ -186,7 +180,9 @@ public class CodeGenerationFormat: BasicFormat {
   }
 }
 
-private func startsOnNewline(_ node: some SyntaxProtocol) -> Bool {
-  return node.leadingTrivia.contains(where: \.isNewline)
-    || node.previousToken(viewMode: .sourceAccurate)?.trailingTrivia.contains(where: \.isNewline) ?? false
+private extension SyntaxProtocol {
+  var startsOnNewline: Bool {
+    return self.leadingTrivia.contains(where: \.isNewline)
+      || self.previousToken(viewMode: .sourceAccurate)?.trailingTrivia.contains(where: \.isNewline) ?? false
+  }
 }