From e7559f0b38af98ee0fdd95842534c18ad240f80f Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Tue, 10 Oct 2017 22:39:11 -0700 Subject: [PATCH 1/2] build: drop default enabled options --- cmake/modules/DispatchCompilerWarnings.cmake | 5 ----- 1 file changed, 5 deletions(-) diff --git a/cmake/modules/DispatchCompilerWarnings.cmake b/cmake/modules/DispatchCompilerWarnings.cmake index d5069c26e..0c9f43e25 100644 --- a/cmake/modules/DispatchCompilerWarnings.cmake +++ b/cmake/modules/DispatchCompilerWarnings.cmake @@ -13,14 +13,9 @@ else() add_compile_options(-Wunreachable-code) add_compile_options(-Wshadow) add_compile_options(-Wconversion) - add_compile_options(-Wconstant-conversion) - add_compile_options(-Wint-conversion) - add_compile_options(-Wbool-conversion) - add_compile_options(-Wenum-conversion) add_compile_options(-Wassign-enum) add_compile_options(-Wshorten-64-to-32) add_compile_options(-Wnewline-eof) - add_compile_options(-Wdeprecated-declarations) add_compile_options(-Wsign-conversion) add_compile_options(-Winfinite-recursion) add_compile_options(-Warray-bounds-pointer-arithmetic) From 5100be88d2234a47e0777590603a169041842b11 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Tue, 10 Oct 2017 22:40:03 -0700 Subject: [PATCH 2/2] build: sort warning options --- cmake/modules/DispatchCompilerWarnings.cmake | 21 ++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/cmake/modules/DispatchCompilerWarnings.cmake b/cmake/modules/DispatchCompilerWarnings.cmake index 0c9f43e25..fa3b2b571 100644 --- a/cmake/modules/DispatchCompilerWarnings.cmake +++ b/cmake/modules/DispatchCompilerWarnings.cmake @@ -8,38 +8,39 @@ else() add_compile_options(-Werror) add_compile_options(-Wall) add_compile_options(-Wextra) - add_compile_options(-Wmissing-prototypes) - add_compile_options(-Wdocumentation) - add_compile_options(-Wunreachable-code) - add_compile_options(-Wshadow) - add_compile_options(-Wconversion) - add_compile_options(-Wassign-enum) - add_compile_options(-Wshorten-64-to-32) - add_compile_options(-Wnewline-eof) - add_compile_options(-Wsign-conversion) - add_compile_options(-Winfinite-recursion) + add_compile_options(-Warray-bounds-pointer-arithmetic) + add_compile_options(-Wassign-enum) add_compile_options(-Watomic-properties) add_compile_options(-Wcomma) add_compile_options(-Wconditional-uninitialized) + add_compile_options(-Wconversion) add_compile_options(-Wcovered-switch-default) add_compile_options(-Wdate-time) add_compile_options(-Wdeprecated) + add_compile_options(-Wdocumentation) add_compile_options(-Wdouble-promotion) add_compile_options(-Wduplicate-enum) add_compile_options(-Wexpansion-to-defined) add_compile_options(-Wfloat-equal) add_compile_options(-Widiomatic-parentheses) + add_compile_options(-Winfinite-recursion) + add_compile_options(-Wmissing-prototypes) + add_compile_options(-Wnewline-eof) add_compile_options(-Wnullable-to-nonnull-conversion) add_compile_options(-Wobjc-interface-ivars) add_compile_options(-Wover-aligned) add_compile_options(-Wpacked) add_compile_options(-Wpointer-arith) add_compile_options(-Wselector) + add_compile_options(-Wshadow) + add_compile_options(-Wshorten-64-to-32) + add_compile_options(-Wsign-conversion) add_compile_options(-Wstatic-in-inline) add_compile_options(-Wsuper-class-method-mismatch) add_compile_options(-Wswitch-enum) add_compile_options(-Wunguarded-availability) + add_compile_options(-Wunreachable-code) add_compile_options(-Wunused) add_compile_options(-Wno-unknown-warning-option)