From 2316abef8f119ae2901aa2f009a611683621f4c5 Mon Sep 17 00:00:00 2001 From: pi1024e Date: Sat, 20 Jul 2019 14:19:00 -0400 Subject: [PATCH] Refactored code to avoid unneeded checks --- CoreFoundation/String.subproj/CFString.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/CoreFoundation/String.subproj/CFString.c b/CoreFoundation/String.subproj/CFString.c index 80cbf5e7bb..4b3b9d49b9 100644 --- a/CoreFoundation/String.subproj/CFString.c +++ b/CoreFoundation/String.subproj/CFString.c @@ -1480,12 +1480,14 @@ CF_PRIVATE CFStringRef __CFStringCreateImmutableFunnel3( useInlineData = true; size = numBytes; - if (hasLengthByte || (encoding != kCFStringEncodingUnicode && __CFCanUseLengthByte(numBytes))) { + if (hasLengthByte) { useLengthByte = true; - if (!hasLengthByte) size += 1; + } else if (encoding != kCFStringEncodingUnicode && __CFCanUseLengthByte(numBytes)) { + useLengthByte = true; + size += 1; } else { size += sizeof(CFIndex); // Explicit length - } + } if (hasNullByte || encoding != kCFStringEncodingUnicode) { useNullByte = true; size += 1;