Skip to content

Commit f34b11f

Browse files
authored
Merge pull request #1277 from spevans/pr_reenable_tests
2 parents bc4bbb1 + f2afeef commit f34b11f

File tree

3 files changed

+16
-17
lines changed

3 files changed

+16
-17
lines changed

TestFoundation/TestCharacterSet.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,10 @@ class TestCharacterSet : XCTestCase {
7676
("test_InlineBuffer", test_InlineBuffer),
7777
("test_Equatable", test_Equatable),
7878
// The following tests must remain disabled until SR-2509 is resolved.
79-
// ("test_Subtracting", test_Subtracting),
80-
// ("test_SubtractEmptySet", test_SubtractEmptySet),
81-
// ("test_SubtractNonEmptySet", test_SubtractNonEmptySet),
82-
// ("test_SymmetricDifference", test_SymmetricDifference),
79+
("test_Subtracting", test_Subtracting),
80+
("test_SubtractEmptySet", test_SubtractEmptySet),
81+
("test_SubtractNonEmptySet", test_SubtractNonEmptySet),
82+
("test_SymmetricDifference", test_SymmetricDifference),
8383
]
8484
}
8585

TestFoundation/TestNSData.swift

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -205,16 +205,16 @@ class TestNSData: XCTestCase {
205205
("test_contentsOfZeroFile", test_contentsOfZeroFile),
206206
("test_basicReadWrite", test_basicReadWrite),
207207
("test_bufferSizeCalculation", test_bufferSizeCalculation),
208-
// ("test_dataHash", test_dataHash), Disabled due to lack of brdiging in swift runtime -- infinite loops
208+
("test_dataHash", test_dataHash),
209209
("test_genericBuffers", test_genericBuffers),
210-
// ("test_writeFailure", test_writeFailure), segfaults
210+
("test_writeFailure", test_writeFailure),
211211
("testBasicConstruction", testBasicConstruction),
212212
("testBridgingDefault", testBridgingDefault),
213213
("testBridgingMutable", testBridgingMutable),
214214
("testCopyBytes_oversized", testCopyBytes_oversized),
215215
("testCopyBytes_ranges", testCopyBytes_ranges),
216216
("testCopyBytes_undersized", testCopyBytes_undersized),
217-
("testCopyBytes", testCopyBytes),
217+
("testCopyBytes", testCopyBytes),
218218
("testCustomDeallocator", testCustomDeallocator),
219219
("testDataInSet", testDataInSet),
220220
("testEquality", testEquality),
@@ -229,8 +229,7 @@ class TestNSData: XCTestCase {
229229
("testReplaceSubrange3", testReplaceSubrange3),
230230
("testReplaceSubrange4", testReplaceSubrange4),
231231
("testReplaceSubrange5", testReplaceSubrange5),
232-
233-
232+
234233
("test_description", test_description),
235234
("test_emptyDescription", test_emptyDescription),
236235
("test_longDescription", test_longDescription),
@@ -259,7 +258,7 @@ class TestNSData: XCTestCase {
259258
("test_initDataWithCount", test_initDataWithCount),
260259
("test_emptyStringToData", test_emptyStringToData),
261260
("test_repeatingValueInitialization", test_repeatingValueInitialization),
262-
261+
263262
("test_sliceAppending", test_sliceAppending),
264263
("test_replaceSubrange", test_replaceSubrange),
265264
("test_sliceWithUnsafeBytes", test_sliceWithUnsafeBytes),

TestFoundation/TestNSDictionary.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class TestNSDictionary : XCTestCase {
2424
static var allTests: [(String, (TestNSDictionary) -> () throws -> Void)] {
2525
return [
2626
("test_BasicConstruction", test_BasicConstruction),
27-
// ("test_ArrayConstruction", test_ArrayConstruction),
27+
("test_ArrayConstruction", test_ArrayConstruction),
2828
("test_description", test_description),
2929
("test_enumeration", test_enumeration),
3030
("test_equality", test_equality),
@@ -60,12 +60,12 @@ class TestNSDictionary : XCTestCase {
6060
XCTAssertEqual(dict2[1] as? NSNumber, NSNumber(value: 2))
6161
}
6262

63-
// func test_ArrayConstruction() {
64-
// let objects = ["foo", "bar", "baz"]
65-
// let keys = ["foo", "bar", "baz"]
66-
// let dict = NSDictionary(objects: objects, forKeys: keys)
67-
// XCTAssertEqual(dict.count, 3)
68-
// }
63+
func test_ArrayConstruction() {
64+
let objects = ["foo", "bar", "baz"]
65+
let keys: [NSString] = ["foo", "bar", "baz"]
66+
let dict = NSDictionary(objects: objects, forKeys: keys)
67+
XCTAssertEqual(dict.count, 3)
68+
}
6969

7070
func test_enumeration() {
7171
let dict : NSDictionary = ["foo" : "bar", "whiz" : "bang", "toil" : "trouble"]

0 commit comments

Comments
 (0)