Skip to content

Commit 8d67adc

Browse files
committed
CGRect.contains(_ point: CGPoint) fixed
1 parent 7f20c4e commit 8d67adc

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Foundation/NSGeometry.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ extension CGRect {
295295
public func contains(_ point: CGPoint) -> Bool {
296296
if self.isNull || self.isEmpty { return false }
297297

298-
return (self.minX...self.maxX).contains(point.x) && (self.minY...self.maxY).contains(point.y)
298+
return (self.minX..<self.maxX).contains(point.x) && (self.minY..<self.maxY).contains(point.y)
299299
}
300300

301301
public func contains(_ rect2: CGRect) -> Bool {

TestFoundation/TestNSGeometry.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,6 +527,7 @@ class TestNSGeometry : XCTestCase {
527527
XCTAssertFalse(r1.contains(CGPoint(x: 7, y: 2)))
528528
XCTAssertFalse(r1.contains(CGPoint(x: 2, y: 7)))
529529
XCTAssertFalse(r1.contains(CGPoint(x: -7, y: -7)))
530+
XCTAssertFalse(r1.contains(CGPoint(x: 15, y: 15)))
530531
XCTAssertTrue(r1.contains(CGPoint(x: 7, y: 7)))
531532
XCTAssertTrue(r1.contains(CGPoint(x: 10, y: 10)))
532533
XCTAssertTrue(r1.contains(CGPoint(x: 5, y: 5)))
@@ -536,9 +537,10 @@ class TestNSGeometry : XCTestCase {
536537
XCTAssertFalse(r2.contains(CGPoint(x: -7, y: -2)))
537538
XCTAssertFalse(r2.contains(CGPoint(x: -2, y: -7)))
538539
XCTAssertFalse(r2.contains(CGPoint(x: 7, y: 7)))
540+
XCTAssertFalse(r2.contains(CGPoint(x: -5, y: -5)))
539541
XCTAssertTrue(r2.contains(CGPoint(x: -7, y: -7)))
540542
XCTAssertTrue(r2.contains(CGPoint(x: -10, y: -10)))
541-
XCTAssertTrue(r2.contains(CGPoint(x: -5, y: -5)))
543+
XCTAssertTrue(r2.contains(CGPoint(x: -15, y: -15)))
542544

543545
XCTAssertTrue(CGRect.infinite.contains(CGPoint()))
544546
}

0 commit comments

Comments
 (0)