Fix segmentation fault by replacing Error with NSError

naithar · naithar · commit 4c2d2c2eb977 · 2016-12-14T09:23:46.000Z
diff --git a/Foundation/NSURLSession/NSURLSessionTask.swift b/Foundation/NSURLSession/NSURLSessionTask.swift
@@ -221,8 +221,8 @@ open class URLSessionTask : NSObject, NSCopying {
      * The error, if any, delivered via -URLSession:task:didCompleteWithError:
      * This property will be nil in the event that no error occured.
      */
-    fileprivate var _error: Error?
-    /*@NSCopying*/ open var error: Error? {
+    fileprivate var _error: NSError?
+    /*@NSCopying*/ open var error: NSError? {
         return self._error
     }
     
diff --git a/TestFoundation/TestNSURLSession.swift b/TestFoundation/TestNSURLSession.swift
@@ -284,7 +284,7 @@ class TestURLSession : XCTestCase {
             XCTAssertNil(error)
             
             XCTAssertNotNil(task.error)
-            XCTAssertEqual((task.error as! NSError).code, NSURLErrorBadURL)
+            XCTAssertEqual(task.error?.code, NSURLErrorBadURL)
         }
     }
     

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ class TestURLSession : XCTestCase {`
`284`	`284`	`XCTAssertNil(error)`
`285`	`285`
`286`	`286`	`XCTAssertNotNil(task.error)`
`287`		`- XCTAssertEqual((task.error as! NSError).code, NSURLErrorBadURL)`
	`287`	`+ XCTAssertEqual(task.error?.code, NSURLErrorBadURL)`
`288`	`288`	`}`
`289`	`289`	`}`
`290`	`290`