Cannot JSON serialize array with boolean value - bug

Author: “saiHemak”

Foundation/NSJSONSerialization.swift

@@ -61,7 +61,7 @@ open class JSONSerialization : NSObject {
             }
 
             // object is NSNumber and is not NaN or infinity
-            if let number = obj as? NSNumber {
+            if let number = _SwiftValue.store(obj) as? NSNumber {
                 let invalid = number.doubleValue.isInfinite || number.doubleValue.isNaN
                 return !invalid
             }
@@ -285,6 +285,8 @@ private struct JSONWriter {
             try serializeDictionary(dict)
         } else if let null = obj as? NSNull {
             try serializeNull(null)
+        } else if let boolVal = obj as? Bool {
+            try serializeNumber(NSNumber(booleanLiteral: boolVal))
         }
         else {
             throw NSError(domain: NSCocoaErrorDomain, code: CocoaError.propertyListReadCorrupt.rawValue, userInfo: ["NSDebugDescription" : "Invalid object cannot be serialized"])

TestFoundation/TestNSJSONSerialization.swift

@@ -597,6 +597,7 @@ extension TestNSJSONSerialization {
             ("test_jsonObjectToOutputStreamFile", test_jsonObjectToOutputStreamFile),
             ("test_invalidJsonObjectToStreamBuffer", test_invalidJsonObjectToStreamBuffer),
             ("test_jsonObjectToOutputStreamInsufficeintBuffer", test_jsonObjectToOutputStreamInsufficeintBuffer),
+            ("test_booleanJSONObject", test_booleanJSONObject),
         ]
     }
 
@@ -928,6 +929,16 @@ extension TestNSJSONSerialization {
         XCTAssertThrowsError(try JSONSerialization.writeJSONObject(str, toStream: outputStream, options: []))
     }
 
+    func test_booleanJSONObject() {
+        do {
+            let mydata = try JSONSerialization.data(withJSONObject: [true])
+            XCTAssertEqual(String(data: mydata, encoding: String.Encoding.utf8),"[1]")
+        } catch {
+            XCTFail("Failed during serialization")
+        }
+        XCTAssertTrue(JSONSerialization.isValidJSONObject([1]))
+    }
+
     private func createTestFile(_ path: String,_contents: Data) -> String? {
         let tempDir = "/tmp/TestFoundation_Playground_" + NSUUID().uuidString + "/"
         do {