Skip to content

Commit 9017b84

Browse files
author
Dan Gohman
committed
Remove a comment about an alternative approach that wouldn't
actually work, at least as described. LLVM Metadata is not intended to suppress LLVM IR rules, as it can be stripped at any time. llvm-svn: 150821
1 parent 905c952 commit 9017b84

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

llvm/lib/Analysis/BasicAliasAnalysis.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -977,10 +977,7 @@ BasicAliasAnalysis::aliasGEP(const GEPOperator *GEP1, uint64_t V1Size,
977977
//
978978
// TODO: Returning PartialAlias instead of MayAlias is a mild hack; the
979979
// practical effect of this is protecting TBAA in the case of dynamic
980-
// indices into arrays of unions. An alternative way to solve this would
981-
// be to have clang emit extra metadata for unions and/or union accesses.
982-
// A union-specific solution wouldn't handle the problem for malloc'd
983-
// memory however.
980+
// indices into arrays of unions or malloc'd memory.
984981
return PartialAlias;
985982
}
986983

0 commit comments

Comments
 (0)