Fix license header check ignoring well known files

The previous PR tried to ignore two well known files `.licenseignore` and `.license_header_template`. However, that PR wasn't fully working and broke this check.

This PR fixes it by using a slightly different approach for those well known files.

Author: FranzBusch

.github/workflows/scripts/check-broken-symlinks.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-# ===----------------------------------------------------------------------===//
+# ===----------------------------------------------------------------------===#
 #
 # This source file is part of the Swift.org open source project
 #
@@ -9,7 +9,7 @@
 # See https://swift.org/LICENSE.txt for license information
 # See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 #
-# ===----------------------------------------------------------------------===//
+# ===----------------------------------------------------------------------===#
 
 set -euo pipefail
 

.github/workflows/scripts/check-docs.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-# ===----------------------------------------------------------------------===//
+# ===----------------------------------------------------------------------===#
 #
 # This source file is part of the Swift.org open source project
 #
@@ -9,7 +9,7 @@
 # See https://swift.org/LICENSE.txt for license information
 # See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 #
-# ===----------------------------------------------------------------------===//
+# ===----------------------------------------------------------------------===#
 
 set -euo pipefail
 

.github/workflows/scripts/check-license-header.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-# ===----------------------------------------------------------------------===//
+# ===----------------------------------------------------------------------===#
 #
 # This source file is part of the Swift.org open source project
 #
@@ -9,7 +9,7 @@
 # See https://swift.org/LICENSE.txt for license information
 # See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 #
-# ===----------------------------------------------------------------------===//
+# ===----------------------------------------------------------------------===#
 
 set -euo pipefail
 
@@ -40,12 +40,12 @@ fi
 
 paths_with_missing_license=( )
 
-file_excludes=".license_header_template
-.licenseignore"
-if [ -f .licenseignore ]; then 
-  file_excludes=$file_excludes$(printf '\n')$(cat .licenseignore)
+if [[ -f .licenseignore ]]; then
+  file_paths=$(tr '\n' '\0' < .licenseignore | xargs -0 -I% printf '":(exclude)%" '| xargs git ls-files ":(exclude).licenseignore" ":(exclude).license_header_template" )
+else
+  file_paths=$(git ls-files ":(exclude).license_header_template" )
 fi
-file_paths=$(echo "$file_excludes" | tr '\n' '\0' | xargs -0 -I% printf '":(exclude)%" '| xargs git ls-files)
+
 
 while IFS= read -r file_path; do
   file_basename=$(basename -- "${file_path}")

.github/workflows/scripts/check-swift-format.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-# ===----------------------------------------------------------------------===//
+# ===----------------------------------------------------------------------===#
 #
 # This source file is part of the Swift.org open source project
 #
@@ -9,7 +9,7 @@
 # See https://swift.org/LICENSE.txt for license information
 # See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 #
-# ===----------------------------------------------------------------------===//
+# ===----------------------------------------------------------------------===#
 
 set -euo pipefail
 

.github/workflows/scripts/check-unacceptable-language.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-# ===----------------------------------------------------------------------===//
+# ===----------------------------------------------------------------------===#
 #
 # This source file is part of the Swift.org open source project
 #
@@ -9,7 +9,7 @@
 # See https://swift.org/LICENSE.txt for license information
 # See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 #
-# ===----------------------------------------------------------------------===//
+# ===----------------------------------------------------------------------===#
 
 set -euo pipefail
 

.license_header_template

@@ -0,0 +1,11 @@
+# ===----------------------------------------------------------------------===#
+#
+# This source file is part of the Swift.org open source project
+#
+# Copyright (c) YEARS Apple Inc. and the Swift project authors
+# Licensed under Apache License v2.0 with Runtime Library Exception
+#
+# See https://swift.org/LICENSE.txt for license information
+# See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+#
+# ===----------------------------------------------------------------------===#

.licenseignore

@@ -0,0 +1,5 @@
+.github/workflows/configs/.flake8
+**/*.yml
+CODEOWNERS
+LICENSE.txt
+README.md

tests/test.py

@@ -1,14 +1,12 @@
 #!/usr/bin/env python3
-##===----------------------------------------------------------------------===##
-##
-## This source file is part of the Swift.org open source project
-##
-## Copyright (c) 2020 Apple Inc. and the Swift.org project authors
-## Licensed under Apache License v2.0
-##
-## See LICENSE.txt for license information
-## See CONTRIBUTORS.txt for the list of Swift.org project authors
-##
-## SPDX-License-Identifier: Apache-2.0
-##
-##===----------------------------------------------------------------------===##
+# ===----------------------------------------------------------------------===#
+#
+# This source file is part of the Swift.org open source project
+#
+# Copyright (c) 2024 Apple Inc. and the Swift project authors
+# Licensed under Apache License v2.0 with Runtime Library Exception
+#
+# See https://swift.org/LICENSE.txt for license information
+# See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+#
+# ===----------------------------------------------------------------------===#