Skip to content

Commit 2ed058b

Browse files
tomerdyim-lee
andauthored
Apply suggestions from code review
Co-authored-by: Yim Lee <yim_lee@apple.com>
1 parent 9258f8e commit 2ed058b

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

Sources/AWSLambdaRuntime/Lambda+Codable.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import NIOFoundationCompat
2121

2222
// MARK: - LambdaHandler Codable support
2323

24-
/// Implementation of a`ByteBuffer` to `Event` decoding.
24+
/// Implementation of `ByteBuffer` to `Event` decoding.
2525
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
2626
extension LambdaHandler where Event: Decodable {
2727
@inlinable
@@ -30,7 +30,7 @@ extension LambdaHandler where Event: Decodable {
3030
}
3131
}
3232

33-
/// Implementation of `Output` to `ByteBuffer` encoding.
33+
/// Implementation of `Output` to `ByteBuffer` encoding.
3434
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
3535
extension LambdaHandler where Output: Encodable {
3636
@inlinable
@@ -40,7 +40,7 @@ extension LambdaHandler where Output: Encodable {
4040
}
4141

4242
/// Default `ByteBuffer` to `Event` decoder using Foundation's `JSONDecoder`.
43-
/// Advanced users that want to inject their own codec can do it by overriding these functions.
43+
/// Advanced users who want to inject their own codec can do it by overriding these functions.
4444
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
4545
extension LambdaHandler where Event: Decodable {
4646
public var decoder: LambdaCodableDecoder {
@@ -49,7 +49,7 @@ extension LambdaHandler where Event: Decodable {
4949
}
5050

5151
/// Default `Output` to `ByteBuffer` encoder using Foundation's `JSONEncoder`.
52-
/// Advanced users that want to inject their own codec can do it by overriding these functions.
52+
/// Advanced users who want to inject their own codec can do it by overriding these functions.
5353
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
5454
extension LambdaHandler where Output: Encodable {
5555
public var encoder: LambdaCodableEncoder {
@@ -59,15 +59,15 @@ extension LambdaHandler where Output: Encodable {
5959

6060
// MARK: - EventLoopLambdaHandler Codable support
6161

62-
/// Implementation of a`ByteBuffer` to `Event` decoding.
62+
/// Implementation of `ByteBuffer` to `Event` decoding.
6363
extension EventLoopLambdaHandler where Event: Decodable {
6464
@inlinable
6565
public func decode(buffer: ByteBuffer) throws -> Event {
6666
try self.decoder.decode(Event.self, from: buffer)
6767
}
6868
}
6969

70-
/// Implementation of `Output` to `ByteBuffer` encoding.
70+
/// Implementation of `Output` to `ByteBuffer` encoding.
7171
extension EventLoopLambdaHandler where Output: Encodable {
7272
@inlinable
7373
public func encode(value: Output, into buffer: inout ByteBuffer) throws {

Sources/AWSLambdaRuntimeCore/LambdaHandler.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ import NIOCore
2626
/// ``ByteBufferLambdaHandler``.
2727
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
2828
public protocol LambdaHandler {
29-
/// The lambda functions input. In most cases this should be `Codable`. If your event originates from an
29+
/// The lambda function's input. In most cases this should be `Codable`. If your event originates from an
3030
/// AWS service, have a look at [AWSLambdaEvents](https://github.com/swift-server/swift-aws-lambda-events),
3131
/// which provides a number of commonly used AWS Event implementations.
3232
associatedtype Event
33-
/// The lambda functions output. Can be `Void`.
33+
/// The lambda function's output. Can be `Void`.
3434
associatedtype Output
3535

3636
init()
@@ -129,7 +129,7 @@ final class CodableLambdaHandler<Underlying: LambdaHandler>: ByteBufferLambdaHan
129129
}
130130
}
131131

132-
/// Implementation of `ByteBuffer` to `Void` decoding.
132+
/// Implementation of `ByteBuffer` to `Void` decoding.
133133
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
134134
extension LambdaHandler where Output == Void {
135135
@inlinable
@@ -232,7 +232,7 @@ public protocol EventLoopLambdaHandler {
232232
func decode(buffer: ByteBuffer) throws -> Event
233233
}
234234

235-
/// Implementation of `ByteBuffer` to `Void` decoding.
235+
/// Implementation of `ByteBuffer` to `Void` decoding.
236236
extension EventLoopLambdaHandler where Output == Void {
237237
@inlinable
238238
public func encode(value: Void, into buffer: inout ByteBuffer) throws {}

0 commit comments

Comments
 (0)