From d4b0dda5340b5aaba9e5d0b000978c80022a0ca1 Mon Sep 17 00:00:00 2001 From: vkill Date: Sat, 24 Aug 2019 12:43:13 +0800 Subject: [PATCH] Fix forgot to set maxAge in Cookie init function --- Sources/AsyncHTTPClient/HTTPClient+HTTPCookie.swift | 1 + .../HTTPClientCookieTests+XCTest.swift | 1 + .../AsyncHTTPClientTests/HTTPClientCookieTests.swift | 12 ++++++++++++ 3 files changed, 14 insertions(+) diff --git a/Sources/AsyncHTTPClient/HTTPClient+HTTPCookie.swift b/Sources/AsyncHTTPClient/HTTPClient+HTTPCookie.swift index 5993fb0e3..b8c70e38e 100644 --- a/Sources/AsyncHTTPClient/HTTPClient+HTTPCookie.swift +++ b/Sources/AsyncHTTPClient/HTTPClient+HTTPCookie.swift @@ -122,6 +122,7 @@ extension HTTPClient { self.path = path self.domain = domain self.expires = expires + self.maxAge = maxAge self.httpOnly = httpOnly self.secure = secure } diff --git a/Tests/AsyncHTTPClientTests/HTTPClientCookieTests+XCTest.swift b/Tests/AsyncHTTPClientTests/HTTPClientCookieTests+XCTest.swift index 00570dab7..c8202b152 100644 --- a/Tests/AsyncHTTPClientTests/HTTPClientCookieTests+XCTest.swift +++ b/Tests/AsyncHTTPClientTests/HTTPClientCookieTests+XCTest.swift @@ -27,6 +27,7 @@ extension HTTPClientCookieTests { return [ ("testCookie", testCookie), ("testCookieDefaults", testCookieDefaults), + ("testCookieInit", testCookieInit), ] } } diff --git a/Tests/AsyncHTTPClientTests/HTTPClientCookieTests.swift b/Tests/AsyncHTTPClientTests/HTTPClientCookieTests.swift index 787c64521..c312a3bca 100644 --- a/Tests/AsyncHTTPClientTests/HTTPClientCookieTests.swift +++ b/Tests/AsyncHTTPClientTests/HTTPClientCookieTests.swift @@ -42,4 +42,16 @@ class HTTPClientCookieTests: XCTestCase { XCTAssertFalse(c.httpOnly) XCTAssertFalse(c.secure) } + + func testCookieInit() { + let c = HTTPClient.Cookie(name: "key", value: "value", path: "/path", domain: "example.com", expires: Date(timeIntervalSince1970: 1_445_412_480), maxAge: 42, httpOnly: true, secure: true) + XCTAssertEqual("key", c.name) + XCTAssertEqual("value", c.value) + XCTAssertEqual("/path", c.path) + XCTAssertEqual("example.com", c.domain) + XCTAssertEqual(Date(timeIntervalSince1970: 1_445_412_480), c.expires) + XCTAssertEqual(42, c.maxAge) + XCTAssertTrue(c.httpOnly) + XCTAssertTrue(c.secure) + } }