Skip to content

Commit b56b4c8

Browse files
committed
fix race in tests
1 parent 2702cb0 commit b56b4c8

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

Tests/AsyncHTTPClientTests/AsyncAwaitEndToEndTests.swift

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -357,8 +357,12 @@ final class AsyncAwaitEndToEndTests: XCTestCase {
357357
let task = Task<HTTPClientResponse, Error> { [request] in
358358
try await client.execute(request, deadline: .now() + .milliseconds(100), logger: logger)
359359
}
360-
await XCTAssertThrowsError(try await task.value) {
361-
XCTAssertEqual($0 as? HTTPClientError, HTTPClientError.deadlineExceeded)
360+
await XCTAssertThrowsError(try await task.value) { error in
361+
guard let error = error as? HTTPClientError else {
362+
return XCTFail("unexpected error \(error)")
363+
}
364+
// a race between deadline and connect timer can result in either error
365+
XCTAssertTrue([.deadlineExceeded, .connectTimeout].contains(error))
362366
}
363367
}
364368
#endif
@@ -378,8 +382,12 @@ final class AsyncAwaitEndToEndTests: XCTestCase {
378382
let task = Task<HTTPClientResponse, Error> { [request] in
379383
try await client.execute(request, deadline: .now(), logger: logger)
380384
}
381-
await XCTAssertThrowsError(try await task.value) {
382-
XCTAssertEqual($0 as? HTTPClientError, HTTPClientError.deadlineExceeded)
385+
await XCTAssertThrowsError(try await task.value) { error in
386+
guard let error = error as? HTTPClientError else {
387+
return XCTFail("unexpected error \(error)")
388+
}
389+
// a race between deadline and connect timer can result in either error
390+
XCTAssertTrue([.deadlineExceeded, .connectTimeout].contains(error))
383391
}
384392
}
385393
#endif

0 commit comments

Comments
 (0)