Skip to content

Commit 80cd7ce

Browse files
Ludovic Dewaillyweissi
Ludovic Dewailly
authored andcommitted
Addressing README.md code snippets as per issue#69 (#70)
1 parent 0c617a4 commit 80cd7ce

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

README.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ httpClient.get(url: "https://swift.org").whenComplete { result in
3939
case .failure(let error):
4040
// process error
4141
case .success(let response):
42-
if let response.status == .ok {
42+
if response.status == .ok {
4343
// handle response
4444
} else {
4545
// handle remote error
@@ -69,7 +69,7 @@ defer {
6969
try? httpClient.syncShutdown()
7070
}
7171

72-
var request = try HTTPClient.HTTPRequest(url: "https://swift.org", method: .POST)
72+
var request = try HTTPClient.Request(url: "https://swift.org", method: .POST)
7373
request.headers.add(name: "User-Agent", value: "Swift HTTPClient")
7474
request.body = .string("some-body")
7575

@@ -78,7 +78,7 @@ httpClient.execute(request: request).whenComplete { result in
7878
case .failure(let error):
7979
// process error
8080
case .success(let response):
81-
if let response.status == .ok {
81+
if response.status == .ok {
8282
// handle response
8383
} else {
8484
// handle remote error
@@ -110,6 +110,9 @@ httpClient.execute(request: request, timeout: timeout)
110110
### Streaming
111111
When dealing with larger amount of data, it's critical to stream the response body instead of aggregating in-memory. Handling a response stream is done using a delegate protocol. The following example demonstrates how to count the number of bytes in a streaming response body:
112112
```swift
113+
import NIO
114+
import NIOHTTP1
115+
113116
class CountingDelegate: HTTPClientResponseDelegate {
114117
typealias Response = Int
115118

@@ -154,7 +157,7 @@ class CountingDelegate: HTTPClientResponseDelegate {
154157
let request = try HTTPClient.Request(url: "https://swift.org")
155158
let delegate = CountingDelegate()
156159

157-
try httpClient.execute(request: request, delegate: delegate).future.whenSuccess { count in
160+
httpClient.execute(request: request, delegate: delegate).futureResult.whenSuccess { count in
158161
print(count)
159162
}
160163
```

0 commit comments

Comments
 (0)