Skip to content

Commit 5156eb2

Browse files
vkillartemredkin
authored andcommitted
Fix forgot to set maxAge in Cookie init function (#91)
1 parent b1eb92e commit 5156eb2

File tree

3 files changed

+14
-0
lines changed

3 files changed

+14
-0
lines changed

Sources/AsyncHTTPClient/HTTPClient+HTTPCookie.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ extension HTTPClient {
122122
self.path = path
123123
self.domain = domain
124124
self.expires = expires
125+
self.maxAge = maxAge
125126
self.httpOnly = httpOnly
126127
self.secure = secure
127128
}

Tests/AsyncHTTPClientTests/HTTPClientCookieTests+XCTest.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ extension HTTPClientCookieTests {
2727
return [
2828
("testCookie", testCookie),
2929
("testCookieDefaults", testCookieDefaults),
30+
("testCookieInit", testCookieInit),
3031
]
3132
}
3233
}

Tests/AsyncHTTPClientTests/HTTPClientCookieTests.swift

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,16 @@ class HTTPClientCookieTests: XCTestCase {
4242
XCTAssertFalse(c.httpOnly)
4343
XCTAssertFalse(c.secure)
4444
}
45+
46+
func testCookieInit() {
47+
let c = HTTPClient.Cookie(name: "key", value: "value", path: "/path", domain: "example.com", expires: Date(timeIntervalSince1970: 1_445_412_480), maxAge: 42, httpOnly: true, secure: true)
48+
XCTAssertEqual("key", c.name)
49+
XCTAssertEqual("value", c.value)
50+
XCTAssertEqual("/path", c.path)
51+
XCTAssertEqual("example.com", c.domain)
52+
XCTAssertEqual(Date(timeIntervalSince1970: 1_445_412_480), c.expires)
53+
XCTAssertEqual(42, c.maxAge)
54+
XCTAssertTrue(c.httpOnly)
55+
XCTAssertTrue(c.secure)
56+
}
4557
}

0 commit comments

Comments
 (0)