From cee7daf14fe42b21622f4c3e5d962e792a260306 Mon Sep 17 00:00:00 2001 From: Em Zhan Date: Sun, 18 May 2025 13:09:09 -0500 Subject: [PATCH 1/3] Fix the tutorial erroring after navigating The `Workspace.reset` method was changed in a non-backward compatible way in commit eb1eb2b0fd, which caused the call in the tutorial pages to not pass the proper value for the selected file. This was missed because the tutorial page didn't use `PageProps` for typing. --- .../src/routes/tutorial/[...slug]/+page.svelte | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte b/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte index ff5bdb9a5c..51d2de3066 100644 --- a/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte +++ b/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte @@ -16,12 +16,9 @@ import Controls from './Controls.svelte'; import Editor from '@sveltejs/repl/editor'; import type { Snapshot } from './$types.js'; + import type { PageProps } from './$types'; - interface Props { - data: any; - } - - let { data }: Props = $props(); + let { data }: PageProps = $props(); let path = data.exercise.path; let show_editor = $state(false); @@ -204,7 +201,7 @@ sidebar.scrollTop = 0; } - workspace.reset(Object.values(a), data.exercise.focus); + workspace.reset(Object.values(a), { tailwind: false }, data.exercise.focus); const will_delete = previous_files.some((file) => !(file.name in a)); From 32fba4ff99b6c4f0b5bbb073f5f3298e5e814d90 Mon Sep 17 00:00:00 2001 From: Em Zhan Date: Sun, 18 May 2025 22:57:00 -0500 Subject: [PATCH 2/3] Remove unneeded type annotation The language server infers this automatically, turns out --- apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte b/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte index 51d2de3066..5a0569b3d3 100644 --- a/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte +++ b/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte @@ -16,9 +16,8 @@ import Controls from './Controls.svelte'; import Editor from '@sveltejs/repl/editor'; import type { Snapshot } from './$types.js'; - import type { PageProps } from './$types'; - let { data }: PageProps = $props(); + let { data } = $props(); let path = data.exercise.path; let show_editor = $state(false); From 1a67bee9db0b7b5302ac2cbc3f600b1312827d25 Mon Sep 17 00:00:00 2001 From: Tee Ming Date: Thu, 22 May 2025 13:20:35 +0800 Subject: [PATCH 3/3] Update +page.svelte --- apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte b/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte index 5a0569b3d3..43ab180e64 100644 --- a/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte +++ b/apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte @@ -15,9 +15,9 @@ import { page } from '$app/state'; import Controls from './Controls.svelte'; import Editor from '@sveltejs/repl/editor'; - import type { Snapshot } from './$types.js'; + import type { Snapshot, PageProps } from './$types.js'; - let { data } = $props(); + let { data }: PageProps = $props(); let path = data.exercise.path; let show_editor = $state(false);