fix: resolve to module scope for top level statements

Author: DMartens

src/scope/index.ts

@@ -3,6 +3,7 @@ import type * as ESTree from "estree";
 import type { TSESTree } from "@typescript-eslint/types";
 import { traverseNodes } from "../traverse";
 import { addElementsToSortedArray, addElementToSortedArray } from "../utils";
+import type { SvelteHTMLNode } from "../ast";
 
 /** Remove all scope, variable, and reference */
 export function removeAllScopeAndVariableAndReference(
@@ -58,9 +59,9 @@ export function removeAllScopeAndVariableAndReference(
  */
 export function getScopeFromNode(
   scopeManager: ScopeManager,
-  currentNode: ESTree.Node
+  currentNode: ESTree.Node | SvelteHTMLNode
 ): Scope {
-  let node: ESTree.Node | null = currentNode;
+  let node: ESTree.Node | SvelteHTMLNode | null = currentNode;
   for (; node; node = (node as any).parent || null) {
     const scope = scopeManager.acquire(node, false);
     if (scope) {
@@ -78,7 +79,10 @@ export function getScopeFromNode(
     }
   }
   const global = scopeManager.globalScope;
-  return global;
+
+  return currentNode.type === "Program" || currentNode.type === "SvelteScriptElement" ?
+         global :
+         getProgramScope(scopeManager);
 }
 /**
  * Gets the scope for the Program node

tests/src/scope/scope.ts

@@ -0,0 +1,61 @@
+import assert from "assert";
+import { parseForESLint } from "../../../src";
+import { getScopeFromNode } from "../../../src/scope";
+
+describe('getScopeFromNode', () => {
+	it('returns the global scope for the root node', () => {
+		const { ast, scopeManager } = parseForESLint('');
+
+		assert.strictEqual(getScopeFromNode(scopeManager, ast), scopeManager.globalScope);
+	});
+
+	it('returns the global scope for the script element', () => {
+		const { ast, scopeManager } = parseForESLint('<script></script>');
+		const script = ast.body[0];
+
+		assert.strictEqual(getScopeFromNode(scopeManager, script), scopeManager.globalScope);
+	});
+
+	it('returns the module scope for nodes for top level nodes of script', () => {
+		const { ast, scopeManager } = parseForESLint('<script>import mod from "mod";</script>');
+		const importStatement = ast.body[0].body[0];
+
+		assert.strictEqual(getScopeFromNode(scopeManager, importStatement), scopeManager.globalScope.childScopes[0]);
+	});
+
+	it('returns the module scope for nested nodes without their own scope', () => {
+		const { ast, scopeManager } = parseForESLint('<script>a || b</script>');
+		const importStatement = ast.body[0].body[0].expression.right;
+
+		assert.strictEqual(getScopeFromNode(scopeManager, importStatement), scopeManager.globalScope.childScopes[0]);
+	});
+
+	it('returns the module scope for nested nodes for non-modules', () => {
+		const { ast, scopeManager } = parseForESLint('<script>a || b</script>', { sourceType: 'script' });
+		const importStatement = ast.body[0].body[0].expression.right;
+
+		assert.strictEqual(getScopeFromNode(scopeManager, importStatement), scopeManager.globalScope.childScopes[0]);
+	});
+
+	it('returns the the child scope of top level nodes with their own scope', () => {
+		const { ast, scopeManager } = parseForESLint('<script>function fn() {}</script>');
+		const fnNode = ast.body[0].body[0];
+
+		assert.strictEqual(getScopeFromNode(scopeManager, fnNode), scopeManager.globalScope.childScopes[0].childScopes[0]);
+	});
+
+	it('returns the own scope for nested nodes', () => {
+		const { ast, scopeManager } = parseForESLint('<script>a || (() => {})</script>');
+		const importStatement = ast.body[0].body[0].expression.right;
+
+		assert.strictEqual(getScopeFromNode(scopeManager, importStatement), scopeManager.globalScope.childScopes[0].childScopes[0]);
+	});
+
+	it('returns the the nearest child scope for statements inside non-global scopes', () => {
+		const { ast, scopeManager } = parseForESLint('<script>function fn() { nested; }</script>');
+		const fnNode = ast.body[0].body[0];
+		const nestedStatement = fnNode.body.body[0];
+
+		assert.strictEqual(getScopeFromNode(scopeManager, nestedStatement), scopeManager.globalScope.childScopes[0].childScopes[0]);
+	});
+});