Skip to content

Commit 4d0e2f3

Browse files
authored
test: add tests for style directive |important modifier (#227)
* test: add tests for style directive `|important` modifier * fix
1 parent 3c4ea54 commit 4d0e2f3

15 files changed

+1683
-5
lines changed

.devcontainer/devcontainer.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,15 @@
1515

1616
// Add the IDs of extensions you want installed when the container is created.
1717
"extensions": [
18-
"dbaeumer.vscode-eslint"
18+
"dbaeumer.vscode-eslint",
19+
"svelte.svelte-vscode"
1920
],
2021

2122
// Use 'forwardPorts' to make a list of ports inside the container available locally.
2223
// "forwardPorts": [],
2324

2425
// Use 'postCreateCommand' to run commands after the container is created.
25-
"postCreateCommand": "npm install",
26+
"postCreateCommand": "yarn install",
2627

2728
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
2829
"remoteUser": "node"

explorer-v2/src/lib/ESLintPlayground.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@
141141
{#each messages as msg, i (`${msg.line}:${msg.column}:${msg.ruleId}@${i}`)}
142142
<li class="message">
143143
[{msg.line}:{msg.column}]:
144-
{msg.message} (<a href={getURL(msg.ruleId)} target="_blank">
144+
{msg.message} (<a href={getURL(msg.ruleId)} target="_blank" rel="noopener noreferrer">
145145
{msg.ruleId}
146146
</a>)
147147
</li>

explorer-v2/src/lib/RulesSettings.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
/>
8989
{rule.ruleId}
9090
</label>
91-
<a href={rule.url} target="_blank"
91+
<a href={rule.url} target="_blank" rel="noopener noreferrer"
9292
><svg
9393
xmlns="http://www.w3.org/2000/svg"
9494
aria-hidden="true"

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"@types/eslint-scope": "^3.7.0",
6161
"@types/eslint-visitor-keys": "^1.0.0",
6262
"@types/mocha": "^10.0.0",
63-
"@types/node": "^16.0.0",
63+
"@types/node": "^18.11.0",
6464
"@types/semver": "^7.3.9",
6565
"@typescript-eslint/eslint-plugin": "^5.4.0",
6666
"@typescript-eslint/parser": "^5.4.0",

tests/fixtures/parser/ast/docs/template-syntax/11-element-directives/05.1-style-property/01-output.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
}
4848
}
4949
},
50+
"modifiers": [],
5051
"range": [
5152
5,
5253
19
@@ -214,6 +215,7 @@
214215
}
215216
}
216217
},
218+
"modifiers": [],
217219
"range": [
218220
36,
219221
50
@@ -363,6 +365,7 @@
363365
}
364366
}
365367
},
368+
"modifiers": [],
366369
"range": [
367370
67,
368371
81

tests/fixtures/parser/ast/docs/template-syntax/11-element-directives/05.1-style-property/02-output.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@
8383
}
8484
}
8585
},
86+
"modifiers": [],
8687
"range": [
8788
35,
8889
46
@@ -470,6 +471,7 @@
470471
}
471472
}
472473
},
474+
"modifiers": [],
473475
"range": [
474476
135,
475477
146
@@ -708,6 +710,7 @@
708710
}
709711
}
710712
},
713+
"modifiers": [],
711714
"range": [
712715
235,
713716
246
@@ -909,6 +912,7 @@
909912
}
910913
}
911914
},
915+
"modifiers": [],
912916
"range": [
913917
304,
914918
315
@@ -963,6 +967,7 @@
963967
}
964968
}
965969
},
970+
"modifiers": [],
966971
"range": [
967972
316,
968973
327
@@ -1036,6 +1041,7 @@
10361041
}
10371042
}
10381043
},
1044+
"modifiers": [],
10391045
"range": [
10401046
336,
10411047
358
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
<!-- Styles can be marked as important -->
2+
<div style:color|important="red">...</div>

0 commit comments

Comments
 (0)