fix: parsing error

Author: ota-meshi

src/parser/typescript/analyze/index.ts

@@ -10,7 +10,7 @@ import {
   removeIdentifierVariable,
   replaceScope,
 } from "../../../scope";
-import { addElementsToSortedArray } from "../../../utils";
+import { addElementsToSortedArray, sortedLastIndex } from "../../../utils";
 import { parseScriptWithoutAnalyzeScope } from "../../script";
 import { TypeScriptContext } from "../context";
 import type { TSESParseForESLintResult } from "../types";
@@ -233,15 +233,28 @@ function transformForDeclareReactiveVar(
   //  function fn () { return foo; }
 
   const openParens: TSESTree.Token[] = [];
+  let eq: TSESTree.Token | null = null;
   const closeParens: TSESTree.Token[] = [];
-  for (const token of tokens) {
+  const startIndex = sortedLastIndex(
+    tokens,
+    (target) => target.range[0] - statement.range[0]
+  );
+  for (let index = startIndex; index < tokens.length; index++) {
+    const token = tokens[index];
     if (
       statement.range[0] <= token.range[0] &&
       token.range[1] <= statement.range[1]
     ) {
       if (token.value === "(" && token.range[1] <= expression.range[0]) {
         openParens.push(token);
       }
+      if (
+        token.value === "=" &&
+        expression.left.range[1] <= token.range[0] &&
+        token.range[1] <= expression.right.range[0]
+      ) {
+        eq = token;
+      }
       if (token.value === ")" && expression.range[1] <= token.range[0]) {
         closeParens.push(token);
       }
@@ -258,7 +271,7 @@ function transformForDeclareReactiveVar(
   ctx.appendOriginal(expression.range[0]);
   ctx.skipUntilOriginalOffset(id.range[0]);
   ctx.appendScript("let ");
-  ctx.appendOriginal(expression.right.range[0]);
+  ctx.appendOriginal(eq ? eq.range[1] : expression.right.range[0]);
   ctx.appendScript(`${functionId}();\nfunction ${functionId}(){return `);
   for (const token of closeParens) {
     ctx.appendOriginal(token.range[0]);

tests/fixtures/integrations/type-info-tests/issue226-input.svelte

@@ -0,0 +1,15 @@
+<script lang="ts">
+type EventInfo = {
+    start_at: number,
+}
+let info: EventInfo | null = null
+
+const lightFormat = (i: Date | number) => i.toString()
+
+fetch('/fakeurl').then(() => { info = { start_at: 0 } }).catch(console.error)
+
+$: startDate = (info?.start_at ? lightFormat(info.start_at) : null)
+const endDate = () => (info?.start_at ? lightFormat(info.start_at) : null)
+</script>
+    
+<input type='text'/>

tests/fixtures/integrations/type-info-tests/issue226-output.json

@@ -0,0 +1 @@
+[]

tests/fixtures/integrations/type-info-tests/issue226-setup.ts

@@ -0,0 +1,24 @@
+/* eslint eslint-comments/require-description: 0, @typescript-eslint/explicit-module-boundary-types: 0 */
+import type { Linter } from "eslint";
+import { BASIC_PARSER_OPTIONS } from "../../../src/parser/test-utils";
+import { rules } from "@typescript-eslint/eslint-plugin";
+export function setupLinter(linter: Linter) {
+  linter.defineRule(
+    "@typescript-eslint/no-unsafe-argument",
+    rules["no-unsafe-argument"] as never
+  );
+}
+
+export function getConfig() {
+  return {
+    parser: "svelte-eslint-parser",
+    parserOptions: BASIC_PARSER_OPTIONS,
+    rules: {
+      "@typescript-eslint/no-unsafe-argument": "error",
+    },
+    env: {
+      browser: true,
+      es2021: true,
+    },
+  };
+}

tests/fixtures/integrations/type-info-tests/plugin-issue254-input.svelte

@@ -0,0 +1,26 @@
+<script lang="ts">
+	let isOpen = false;
+
+	let id: string | undefined = undefined;
+</script>
+
+<h1>Welcome to SvelteKit</h1>
+<p>Visit <a href="https://kit.svelte.dev">kit.svelte.dev</a> to read the documentation</p>
+
+<button on:click={() => (isOpen = !isOpen)} />
+
+{#if !isOpen}
+	<div>{id}</div>
+{/if}
+
+{#if !isOpen && id}
+	<div>{id}</div>
+{/if}
+
+{#if !isOpen && !!id}
+	<div>only visible when isOpen and id</div>
+{/if}
+
+{#if !isOpen && id !== undefined}
+	<div>only visible when isopen and id</div>
+{/if}

tests/fixtures/integrations/type-info-tests/plugin-issue254-output.json

@@ -0,0 +1 @@
+[]

tests/fixtures/integrations/type-info-tests/plugin-issue254-setup.ts

@@ -0,0 +1,24 @@
+/* eslint eslint-comments/require-description: 0, @typescript-eslint/explicit-module-boundary-types: 0 */
+import type { Linter } from "eslint";
+import { BASIC_PARSER_OPTIONS } from "../../../src/parser/test-utils";
+import { rules } from "@typescript-eslint/eslint-plugin";
+export function setupLinter(linter: Linter) {
+  linter.defineRule(
+    "@typescript-eslint/no-unnecessary-condition",
+    rules["no-unnecessary-condition"] as never
+  );
+}
+
+export function getConfig() {
+  return {
+    parser: "svelte-eslint-parser",
+    parserOptions: BASIC_PARSER_OPTIONS,
+    rules: {
+      "@typescript-eslint/no-unnecessary-condition": "error",
+    },
+    env: {
+      browser: true,
+      es2021: true,
+    },
+  };
+}

tests/fixtures/parser/ast/ts-issue226-input.svelte

@@ -0,0 +1,15 @@
+<script lang="ts">
+type EventInfo = {
+    start_at: number,
+}
+let info: EventInfo | null = null
+
+const lightFormat = (i: Date | number) => i.toString()
+
+fetch('/fakeurl').then(() => { info = { start_at: 0 } }).catch(console.error)
+
+$: startDate = (info?.start_at ? lightFormat(info.start_at) : null)
+const endDate = () => (info?.start_at ? lightFormat(info.start_at) : null)
+</script>
+    
+<input type='text'/>

tests/fixtures/parser/ast/ts-issue226-no-unused-vars-result.json

@@ -0,0 +1,14 @@
+[
+  {
+    "ruleId": "no-unused-vars",
+    "code": "startDate",
+    "line": 11,
+    "column": 4
+  },
+  {
+    "ruleId": "no-unused-vars",
+    "code": "endDate",
+    "line": 12,
+    "column": 7
+  }
+]