Skip to content

Commit 24c10d0

Browse files
authored
fix linting messages when using write-only store (#108)
1 parent 4715a5c commit 24c10d0

File tree

4 files changed

+20
-2
lines changed

4 files changed

+20
-2
lines changed

src/preprocess.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export const preprocess = text => {
6363
}
6464
const { ast, warnings, vars, mapper } = result;
6565

66-
const references_and_reassignments = `{${vars.filter(v => v.referenced).map(v => v.name)};${vars.filter(v => v.reassigned || v.export_name).map(v => v.name + '=0')}}`;
66+
const references_and_reassignments = `{${vars.filter(v => v.referenced || v.name[0] === '$').map(v => v.name)};${vars.filter(v => v.reassigned || v.export_name).map(v => v.name + '=0')}}`;
6767
state.var_names = new Set(vars.map(v => v.name));
6868

6969
// convert warnings to linting messages
@@ -184,7 +184,7 @@ export const preprocess = text => {
184184
},
185185
});
186186

187-
block.transformed_code += `{${vars.filter(v => v.referenced_from_script).map(v => v.name)}}`;
187+
block.transformed_code += `{${vars.filter(v => v.referenced_from_script || v.name[0] === '$').map(v => v.name)}}`;
188188
}
189189

190190
// return processed string
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module.exports = {
2+
rules: {
3+
"no-unused-vars": "error",
4+
},
5+
};
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<script>
2+
import { imported, createStore } from './store.js';
3+
4+
const writeOnly = createStore();
5+
$writeOnly = 99;
6+
7+
const readOnly = createStore();
8+
$readOnly;
9+
10+
$imported = 'some value';
11+
</script>
12+
<div on:click={() => $imported = 'clicked' }/>
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
[]

0 commit comments

Comments
 (0)