From 22d8e9a75a6e949a499cdb7f48a5d8892405972d Mon Sep 17 00:00:00 2001 From: ota-meshi Date: Fri, 1 Mar 2024 09:11:11 +0900 Subject: [PATCH 1/2] fix: style report location --- src/utils/css-utils/style-attribute.ts | 5 +---- .../prefer-style-directive/invalid/test04-errors.yaml | 8 ++++++++ .../prefer-style-directive/invalid/test04-input.svelte | 3 +++ .../prefer-style-directive/invalid/test04-output.svelte | 3 +++ 4 files changed, 15 insertions(+), 4 deletions(-) create mode 100644 tests/fixtures/rules/prefer-style-directive/invalid/test04-errors.yaml create mode 100644 tests/fixtures/rules/prefer-style-directive/invalid/test04-input.svelte create mode 100644 tests/fixtures/rules/prefer-style-directive/invalid/test04-output.svelte diff --git a/src/utils/css-utils/style-attribute.ts b/src/utils/css-utils/style-attribute.ts index f4988ddbd..b7fa497ed 100644 --- a/src/utils/css-utils/style-attribute.ts +++ b/src/utils/css-utils/style-attribute.ts @@ -353,10 +353,7 @@ function convertChild( /** convert range */ function convertRange(node: AnyNode, ctx: Ctx): AST.Range { - return [ - ctx.startOffset + node.source!.start!.offset, - ctx.startOffset + node.source!.end!.offset + 1 - ]; + return [ctx.startOffset + node.source!.start!.offset, ctx.startOffset + node.source!.end!.offset]; } /** convert range */ diff --git a/tests/fixtures/rules/prefer-style-directive/invalid/test04-errors.yaml b/tests/fixtures/rules/prefer-style-directive/invalid/test04-errors.yaml new file mode 100644 index 000000000..f037d0194 --- /dev/null +++ b/tests/fixtures/rules/prefer-style-directive/invalid/test04-errors.yaml @@ -0,0 +1,8 @@ +- message: Can use style directives instead. + line: 1 + column: 13 + suggestions: null +- message: Can use style directives instead. + line: 1 + column: 28 + suggestions: null diff --git a/tests/fixtures/rules/prefer-style-directive/invalid/test04-input.svelte b/tests/fixtures/rules/prefer-style-directive/invalid/test04-input.svelte new file mode 100644 index 000000000..1771e58e3 --- /dev/null +++ b/tests/fixtures/rules/prefer-style-directive/invalid/test04-input.svelte @@ -0,0 +1,3 @@ +
+ foo +
\ No newline at end of file diff --git a/tests/fixtures/rules/prefer-style-directive/invalid/test04-output.svelte b/tests/fixtures/rules/prefer-style-directive/invalid/test04-output.svelte new file mode 100644 index 000000000..a8c2eb7b7 --- /dev/null +++ b/tests/fixtures/rules/prefer-style-directive/invalid/test04-output.svelte @@ -0,0 +1,3 @@ +
+ foo +
\ No newline at end of file From ace31f0f4e5ee491cc6570d47c2e947acccd7570 Mon Sep 17 00:00:00 2001 From: Yosuke Ota Date: Fri, 1 Mar 2024 09:12:29 +0900 Subject: [PATCH 2/2] Create blue-plants-pump.md --- .changeset/blue-plants-pump.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/blue-plants-pump.md diff --git a/.changeset/blue-plants-pump.md b/.changeset/blue-plants-pump.md new file mode 100644 index 000000000..629eec61e --- /dev/null +++ b/.changeset/blue-plants-pump.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-svelte": patch +--- + +fix: style report location